From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F2ECFF5137 for ; Tue, 7 Apr 2026 19:39:59 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id D562A10E4C7; Tue, 7 Apr 2026 19:39:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="svL9lTOT"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 9E0864532F; Tue, 7 Apr 2026 19:28:22 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1775590102; b=bcAli/hQqclESarQlj/aFOnMWuJqw/DlHHcWKMdQ3cUo2pknyQHx3MYD7RSo9ouPGYNeu cz59uwixTcc/kYYhEQsct4e7P8QJEPC6tCDHEYZ1Ay6ynITWlFSNv2dPBtEb1kUZq9JXI1O Fu+BEAd8BQyb16HO1988SDB0XZg7PGZD6avLZ3NSJd/B5lSWOl3/2Y75GXG4XF8m5zamwQV 3JllRaXMHZBKnJW/OnRSZN3/HOmnpSd6+fv31wfNwXGCs86j1Ff85nn5R1QODzio7LTtkbY CnCP1oKzjS3VB6n5AqpHssL2q9ZGDRnMVpsAXcuC0Reso1QEv3QoLiWEQLyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1775590102; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=ezxYGDLbIpJfhedHBu/G6U/yF1cUvLSAG24BHXC26WY=; b=F4zo6tiB5ATt5PgSwjD9f1qMEl0UPZBMb77Ws08NrNAsUQ2HiuaOD1UKthCb4GYjrcX4k C1w+Dm2kjC2GU+IamFaWkkvr9kWZYvZAfNdrrYSZrWyqoze8FJ6u+qMsTVLT2I0uaHTWlEC USTS7OXT0RlSSV2k6knGw1QWeJ8kl4LwbgWxjKa19n32lSicTBQlXggRN4yb28trEedyxlt RYP5veKXxPIx6Ad4O3N0YJc+3BpDOJnc+UL5OatJ6mngB+ivfSB1MN6TMdAEJZBFYNiOzp5 trJYm8HSOeSYbbrujF+W1oTww44166bq8KC91lzKaC/wcqkLDh+Yl4KZygug== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Authentication-Results: mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id DED7E4532F for ; Tue, 7 Apr 2026 19:28:18 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3A4A10E4BD; Tue, 7 Apr 2026 19:39:54 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BDF81444E8; Tue, 7 Apr 2026 19:39:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D7DEC2BC9E; Tue, 7 Apr 2026 19:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775590794; bh=VUPbEqFGGbOFWIwXYHWvivFzwPWAABqvcwZPV7b0Qgs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=svL9lTOTlQvQW0aFeFKP/n5yfvO3GIW0MAh6CQjV8BDjzRyW110HJqQrlD2OHyqtS Q692ehekWJW1duvyjeW/LnXHSp1n3mpWZaBk/xLCaLVeBZEkNI7D1oxaJlKWl+nRu9 MD9N2qhC6DuDbgoJZ4YDrVlvpBOJ7yNWOojg41Ywe36x+PieL81EJg2L9U1AoNe0bS n1kxPN3enhPp93NsycEDtH74lRzyCtF+jbuz4X/nLe5ukrZT49KmvSpj5+6QeACdNv /8Enc1MenSmwjSptV9YecbQcl0TXA+nhfF3Bbo3ytWFXK7DZley68PuTxeTONWE4NR aRSRs5uDp+BcA== Date: Tue, 7 Apr 2026 21:35:58 +0200 From: Nicolas Schier To: Miguel Ojeda Subject: Re: [PATCH v2 33/33] rust: kbuild: allow `clippy::precedence` for Rust < 1.86.0 Message-ID: Mail-Followup-To: Nicolas Schier , Miguel Ojeda , Nathan Chancellor , Danilo Krummrich , Andreas Hindborg , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Courbot , David Airlie , Simona Vetter , Brendan Higgins , David Gow , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Christian Brauner , Carlos Llamas , Alice Ryhl , Jonathan Corbet , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Trevor Gross , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, Lorenzo Stoakes , Vlastimil Babka , "Liam R . Howlett" , Uladzislau Rezki , linux-block@vger.kernel.org, moderated for non-subscribers , Alexandre Ghiti , linux-riscv@lists.infradead.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Nick Desaulniers , Bill Wendling , Justin Stitt , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Shuah Khan , linux-doc@vger.kernel.org, Tamir Duberstein References: <20260405235309.418950-1-ojeda@kernel.org> <20260405235309.418950-34-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260405235309.418950-34-ojeda@kernel.org> Message-ID-Hash: OTDJPOAR5VQFFPP2I7U3Y4XR27FNYQQH X-Message-ID-Hash: OTDJPOAR5VQFFPP2I7U3Y4XR27FNYQQH X-MailFrom: nsc@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Nathan Chancellor , Danilo Krummrich , Andreas Hindborg , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Courbot , Simona Vetter , Brendan Higgins , David Gow , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Christian Brauner , Carlos Llamas , Alice Ryhl , Jonathan Corbet , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Trevor Gross , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, Lorenzo Stoakes , Vlastimil Babka , "Liam R . Howlett" , Uladzislau Rezki , linux-block@vger.kernel.org, moderated for non-subscribers , Alexandre Ghiti , linux-riscv@lists.infradead.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Nick Desaulniers , Bill Wendling , Justin Stitt , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Shuah Khan , linux-doc@vger.kernel.org, Tamir Duberstein X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Apr 06, 2026 at 01:53:09AM +0200, Miguel Ojeda wrote: > The Clippy `precedence` lint was extended in Rust 1.85.0 to include > bitmasking and shift operations [1]. However, because it generated > many hits, in Rust 1.86.0 it was split into a new `precedence_bits` > lint which is not enabled by default [2]. > > In other words, only Rust 1.85 has a different behavior. For instance, > it reports: > > warning: operator precedence can trip the unwary > --> drivers/gpu/nova-core/fb/hal/ga100.rs:16:5 > | > 16 | / u64::from(regs::NV_PFB_NISO_FLUSH_SYSMEM_ADDR::read(bar).adr_39_08()) << FLUSH_SYSMEM_ADDR_SHIFT > 17 | | | u64::from(regs::NV_PFB_NISO_FLUSH_SYSMEM_ADDR_HI::read(bar).adr_63_40()) > 18 | | << FLUSH_SYSMEM_ADDR_SHIFT_HI > | |_________________________________________^ > | > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence > = note: `-W clippy::precedence` implied by `-W clippy::all` > = help: to override `-W clippy::all` add `#[allow(clippy::precedence)]` > help: consider parenthesizing your expression > | > 16 ~ (u64::from(regs::NV_PFB_NISO_FLUSH_SYSMEM_ADDR::read(bar).adr_39_08()) << FLUSH_SYSMEM_ADDR_SHIFT) | (u64::from(regs::NV_PFB_NISO_FLUSH_SYSMEM_ADDR_HI::read(bar).adr_63_40()) > 17 + << FLUSH_SYSMEM_ADDR_SHIFT_HI) > | > > While so far we try our best to keep all versions Clippy-clean, the > minimum (which is now Rust 1.85.0 after the bump) and the latest stable > are the most important ones; and this may be considered a "false positive" > with respect to the behavior in other versions. > > Thus allow this lint for this version using the per-version flags > mechanism introduced in the previous commit. > > Link: https://github.com/rust-lang/rust-clippy/issues/14097 [1] > Link: https://github.com/rust-lang/rust-clippy/pull/14115 [2] > Link: https://lore.kernel.org/rust-for-linux/DFVDKMMA7KPC.2DN0951H3H55Y@kernel.org/ > Reviewed-by: Tamir Duberstein > Reviewed-by: Gary Guo > Signed-off-by: Miguel Ojeda > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Nicolas Schier -- Nicolas