From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 33165] [NVA3, NVA8] gpu lockup during driver probe Date: Sun, 09 Mar 2014 16:34:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1108205228==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============1108205228== Content-Type: multipart/alternative; boundary="1394382876.d27fB61B6.29529"; charset="us-ascii" --1394382876.d27fB61B6.29529 Date: Sun, 9 Mar 2014 16:34:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freedesktop.org/show_bug.cgi?id=3D33165 --- Comment #30 from Oleg Bulatov --- Comment on attachment 95408 --> https://bugs.freedesktop.org/attachment.cgi?id=3D95408 initialize stuff for gddr5 ram Review of attachment 95408: ----------------------------------------------------------------- ::: drivers/gpu/drm/nouveau/core/subdev/fb/ramnva3.c @@ +365,5 @@ > + /* XXX this algorithm is insane, find some sanity to it. */ > + /* [1] MMIO32 R 0x100268 0x30030200 PFB.SUBPART_CONFIG =3D> { SELECT_M= ASK =3D 0x2 | UNK16 =3D 0x3 | ENABLE_MASK =3D 0x3 } */ > + nv_wr32(pfb, 0x10fcac, 0x00001f01); > + for (o =3D 0; o < 4; o++) { > + int off =3D offsets[i]; maybe int off =3D offsets[o]; ? @@ +387,5 @@ > + for (i =3D 0x20, idx =3D 0; i < 0x30; i++, idx++) { > + int pat =3D pattern[2 + (idx % 2)]; > + if (i =3D=3D 0x26) > + pat =3D 0; > + if (i =3D=3D 0x1f) looks like this condition is always false in this for-loop --=20 You are receiving this mail because: You are the assignee for the bug. --1394382876.d27fB61B6.29529 Date: Sun, 9 Mar 2014 16:34:36 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Commen= t # 30 on bug 33165<= /a> from Oleg Bulatov 
Comment on attachme=
nt 95408 [details] [review]
initialize stuff for gddr5 ram

Review of attachment 95408 <=
a href=3D"attachment.cgi?id=3D95408&action=3Dedit" title=3D"initialize =
stuff for gddr5 ram">[details] [review]:
-----------------------------------------------------------------

::: drivers/gpu/drm/nouveau/core/subdev/fb/ramnva3.c
@@ +365,5 @@
> +		/* XXX this algorithm is insane, find some sa=
nity to it. */
> +		/* [1] MMIO32 R 0x100268 0x30030200 PFB.SUBPART_CONFIG =3D> { SE=
LECT_MASK =3D 0x2 | UNK16 =3D 0x3 | ENABLE_MASK =3D 0x3 } */
> +		nv_wr32(pfb, 0x10fcac, 0x00001f01);
> +		for (o =3D 0; o < 4; o++) {
> +			int off =3D offsets[i];

maybe int off =3D offsets[o]; ?

@@ +387,5 @@
> +			for (i =3D 0x20, idx =3D 0; i < 0x30; i++=
, idx++) {
> +				int pat =3D pattern[2 + (idx % 2)];
> +				if (i =3D=3D 0x26)
> +					pat =3D 0;
> +				if (i =3D=3D 0x1f)

looks like this condition is always false in this for-loop

You are receiving this mail because: =20=20=20=20=20=20
  • You are the assignee for the bug.
--1394382876.d27fB61B6.29529-- --===============1108205228== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau --===============1108205228==--