From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY Date: Sat, 24 Aug 2013 04:06:15 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0965030519==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============0965030519== Content-Type: multipart/alternative; boundary="1377317175.8B18C1.8984"; charset="us-ascii" --1377317175.8B18C1.8984 Date: Sat, 24 Aug 2013 04:06:15 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=57660 --- Comment #9 from Martin Peres --- (In reply to comment #8) > Sounds like what's left to be done is to test it. Just need to apply the > below patch and see if it works (looks like there are a couple of piglit > tests... ls bin/*cube_map_array* -- they ought to pass on the nva3+ > hardware). > > --- a/src/gallium/drivers/nv50/nv50_screen.c > +++ b/src/gallium/drivers/nv50/nv50_screen.c > @@ -114,10 +114,7 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum > pipe_cap param) > case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE: > return 0; > case PIPE_CAP_CUBE_MAP_ARRAY: > - return 0; > - /* > return nv50_screen(pscreen)->tesla->oclass >= NVA3_3D_CLASS; > - */ > case PIPE_CAP_TWO_SIDED_STENCIL: > case PIPE_CAP_DEPTH_CLIP_DISABLE: > case PIPE_CAP_POINT_SPRITE: I tested this patch with piglit, it doesn't look good :D * arb_texture_cube_map_array-get: PASS * arb_texture_cube_map_array-teximage3d-invalid-values: PASS * arb_texture_cube_map_array-cubemap: FAIL (http://codepad.org/sZpx3ajS) * arb_texture_cube_map_array-cubemap-lod: FAIL (http://codepad.org/5E8EPmpx) * arb_texture_cube_map_array-fbo-cubemap-array: FAIL (http://codepad.org/0QqPUEAE) * arb_texture_cube_map_array-sampler-cube-array-shadow: FAIL (http://codepad.org/orzd5RoU) -- You are receiving this mail because: You are the assignee for the bug. --1377317175.8B18C1.8984 Date: Sat, 24 Aug 2013 04:06:15 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"

Comment # 9 on bug 57660 from 
(In reply to comment #8)
> Sounds like what's left to be done is to test it. Just need to apply the
> below patch and see if it works (looks like there are a couple of piglit
> tests... ls bin/*cube_map_array* -- they ought to pass on the nva3+
> hardware).
> 
> --- a/src/gallium/drivers/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nv50/nv50_screen.c
> @@ -114,10 +114,7 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum
> pipe_cap param)
>     case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
>        return 0;
>     case PIPE_CAP_CUBE_MAP_ARRAY:
> -      return 0;
> -      /*
>        return nv50_screen(pscreen)->tesla->oclass >= NVA3_3D_CLASS;
> -      */
>     case PIPE_CAP_TWO_SIDED_STENCIL:
>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>     case PIPE_CAP_POINT_SPRITE:

I tested this patch with piglit, it doesn't look good :D

* arb_texture_cube_map_array-get: PASS
* arb_texture_cube_map_array-teximage3d-invalid-values: PASS
* arb_texture_cube_map_array-cubemap: FAIL (http://codepad.org/sZpx3ajS)
* arb_texture_cube_map_array-cubemap-lod: FAIL (http://codepad.org/5E8EPmpx)
* arb_texture_cube_map_array-fbo-cubemap-array: FAIL
(http://codepad.org/0QqPUEAE)
* arb_texture_cube_map_array-sampler-cube-array-shadow: FAIL
(http://codepad.org/orzd5RoU)

You are receiving this mail because:
  • You are the assignee for the bug.
--1377317175.8B18C1.8984-- --===============0965030519== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau --===============0965030519==--