From: John Hubbard <jhubbard@nvidia.com>
To: Timur Tabi <ttabi@nvidia.com>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
Alexandre Courbot <acourbot@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
Eliot Courtney <ecourtney@nvidia.com>
Subject: Re: [PATCH v2 3/7] gpu: nova-core: use the TLV heap sizes for pmu and non-wpr
Date: Fri, 20 Nov 2026 14:53:51 -0800 [thread overview]
Message-ID: <03436183-9dab-426a-9283-28e988b238db@nvidia.com> (raw)
In-Reply-To: <1f88322ae5c6d879b293b2f2a96a36413dbafef3.camel@nvidia.com>
On 11/20/26 2:33 PM, Timur Tabi wrote:
> On Fri, 2026-11-20 at 15:47 +0900, Eliot Courtney wrote:
...
> Honestly, I've never been a fan of adding and then removing unused-code attributes within a
> patch set. If you're telling me that they now depend on the the Rust compiler version, then
We are stuck doing this, though.
> maybe we need to relax these rules a bit.
>
> Just FYI, when building this tree, I already get warnings like this. I've just ignored them.
Please don't get accustomed to ignoring Rust build warnings, because Nova
(and Rust for Linux) are expected to build completely cleanly.
The convention is very strongly "no warnings on the build".
>
> warning: this lint expectation is unfulfilled
> --> drivers/gpu/nova-core/gsp/nvkv/encode.rs:4:45
> |
> 4 | #![cfg_attr(not(CONFIG_KUNIT = "y"), expect(dead_code))]
> | ^^^^^^^^^
>
> warning: this lint expectation is unfulfilled
> --> drivers/gpu/nova-core/gsp/nvkv/decode.rs:4:45
> |
> 4 | #![cfg_attr(not(CONFIG_KUNIT = "y"), expect(dead_code))]
> | ^^^^^^^^^
Eliot can fix those, but only if he knows about them. Don't suffer
in silence. :)
thanks,
--
John Hubbard
next prev parent reply other threads:[~2026-11-20 22:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:54 [PATCH v2 0/7] Transition nova-core to use TLV variables for heap sizes Timur Tabi
2026-11-16 19:54 ` [PATCH v2 1/7] gpu: nova-core: add Tlv.get_u64 Timur Tabi
2026-11-18 4:51 ` Eliot Courtney
2026-11-16 19:54 ` [PATCH v2 2/7] gpu: nova-core: read GSP heap variables from TLV Timur Tabi
2026-11-20 5:23 ` Eliot Courtney
2026-11-20 18:49 ` Timur Tabi
2026-11-16 19:54 ` [PATCH v2 3/7] gpu: nova-core: use the TLV heap sizes for pmu and non-wpr Timur Tabi
2026-11-20 6:47 ` Eliot Courtney
2026-11-20 22:33 ` Timur Tabi
2026-11-20 22:53 ` John Hubbard [this message]
2026-11-16 19:54 ` [PATCH v2 4/7] gpu: nova-core: remove heap size related HAL functions Timur Tabi
2026-11-20 6:47 ` Eliot Courtney
2026-11-16 19:54 ` [PATCH v2 5/7] gpu: nova-core: add TLV versions of WPR heap size functions Timur Tabi
2026-11-20 7:01 ` Eliot Courtney
2026-11-20 22:49 ` Timur Tabi
2026-11-16 19:54 ` [PATCH v2 6/7] gpu: nova-core: change wpr2_heap_params to use TLV values Timur Tabi
2026-11-20 7:27 ` Eliot Courtney
2026-11-16 19:54 ` [PATCH v2 7/7] gpu: nova-core: remove LibosParams Timur Tabi
2026-11-20 6:53 ` Eliot Courtney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03436183-9dab-426a-9283-28e988b238db@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=nova-gpu@lists.linux.dev \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox