NVIDIA GPU driver infrastructure
 help / color / mirror / Atom feed
From: Timur Tabi <ttabi@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
	Miguel Ojeda <ojeda@kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	Russ Weight <russ.weight@linux.dev>,
	"Gary Guo" <gary@garyguo.net>,
	Alexandre Courbot <acourbot@nvidia.com>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>, <zhiw@nvidia.com>,
	<rust-for-linux@vger.kernel.org>, <driver-core@lists.linux.dev>,
	<nova-gpu@lists.linux.dev>
Subject: [PATCH v6 8/8] gpu: nova-core: update firmware module info for TLV images
Date: Wed, 29 Jul 2026 17:55:34 -0500	[thread overview]
Message-ID: <20260729225534.2046933-9-ttabi@nvidia.com> (raw)
In-Reply-To: <20260729225534.2046933-1-ttabi@nvidia.com>

Now that nova-core loads the TLV firmware images, update the firmware
module info to specify those files.

Also remove FIRMWARE_VERSION as it is no longer used.

Signed-off-by: Timur Tabi <ttabi@nvidia.com>
---
 drivers/gpu/nova-core/firmware.rs | 12 ++++--------
 drivers/gpu/nova-core/gsp/hal.rs  |  8 ++++----
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/nova-core/firmware.rs b/drivers/gpu/nova-core/firmware.rs
index d58a3d5770d5..b49613a90bf0 100644
--- a/drivers/gpu/nova-core/firmware.rs
+++ b/drivers/gpu/nova-core/firmware.rs
@@ -29,8 +29,6 @@
 pub(crate) mod riscv;
 pub(crate) mod tlv;
 
-pub(crate) const FIRMWARE_VERSION: &str = "570.144";
-
 /// Structure used to describe some firmwares, notably FWSEC-FRTS.
 #[repr(C)]
 #[derive(Debug, Clone, FromBytes)]
@@ -338,10 +336,7 @@ const fn make_entry_file(self, chipset: &str, fw: &str) -> Self {
                 .push("nvidia/")
                 .push(chipset)
                 .push("/gsp/")
-                .push(fw)
-                .push("-")
-                .push(FIRMWARE_VERSION)
-                .push(".bin"),
+                .push(fw),
         )
     }
 
@@ -350,8 +345,9 @@ const fn make_entry_chipset(self, chipset: gpu::Chipset) -> Self {
 
         // GSP firmware files are always present.
         let mut this = self
-            .make_entry_file(name, "bootloader")
-            .make_entry_file(name, "gsp");
+            .make_entry_file(name, "gsp_bootloader.tlv")
+            .make_entry_file(name, "gsp.tlv")
+            .make_entry_file(name, "gsp.bin");
 
         // Add the firmware files specific to the GSP boot method of `chipset`.
         let boot_files = boot_firmware_files(chipset);
diff --git a/drivers/gpu/nova-core/gsp/hal.rs b/drivers/gpu/nova-core/gsp/hal.rs
index 34b4bb82a999..2177ea17dee6 100644
--- a/drivers/gpu/nova-core/gsp/hal.rs
+++ b/drivers/gpu/nova-core/gsp/hal.rs
@@ -67,16 +67,16 @@ fn post_boot(
 pub(crate) const fn boot_firmware_files(chipset: Chipset) -> &'static [&'static str] {
     match chipset.arch() {
         // Turing chipsets boot the GSP via the SEC2 Booter, and require the FWSEC bootloader.
-        Architecture::Turing => &["booter_load", "booter_unload", "gen_bootloader"],
+        Architecture::Turing => &["booter_load.tlv", "booter_unload.tlv", "gen_bootloader.tlv"],
         // GA100 also requires the FWSEC bootloader.
         Architecture::Ampere if matches!(chipset, Chipset::GA100) => {
-            &["booter_load", "booter_unload", "gen_bootloader"]
+            &["booter_load.tlv", "booter_unload.tlv", "gen_bootloader.tlv"]
         }
         // Other Ampere chipsets, as well as Ada chipsets, run FWSEC directly.
-        Architecture::Ampere | Architecture::Ada => &["booter_load", "booter_unload"],
+        Architecture::Ampere | Architecture::Ada => &["booter_load.tlv", "booter_unload.tlv"],
         // Hopper and later chipsets boot the GSP via the FMC image loaded by FSP.
         Architecture::Hopper | Architecture::BlackwellGB10x | Architecture::BlackwellGB20x => {
-            &["fmc"]
+            &["fmc.tlv"]
         }
     }
 }
-- 
2.54.0


      parent reply	other threads:[~2026-07-29 22:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 22:55 [PATCH v6 0/8] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-29 22:55 ` [PATCH v6 1/8] rust: alloc: add Vec::zeroed method Timur Tabi
2026-07-29 22:55 ` [PATCH v6 2/8] rust: firmware: add request_into_buf() Timur Tabi
2026-07-29 22:55 ` [PATCH v6 3/8] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-29 22:55 ` [PATCH v6 4/8] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-29 22:55 ` [PATCH v6 5/8] gpu: nova-core: transition gsp " Timur Tabi
2026-07-29 23:24   ` Timur Tabi
2026-07-29 22:55 ` [PATCH v6 6/8] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-29 22:55 ` [PATCH v6 7/8] gpu: nova-core: transition fsp " Timur Tabi
2026-07-29 22:55 ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729225534.2046933-9-ttabi@nvidia.com \
    --to=ttabi@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=mcgrof@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox