From: Timur Tabi <ttabi@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
"lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>, Zhi Wang <zhiw@nvidia.com>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"boqun@kernel.org" <boqun@kernel.org>,
"daniel.almeida@collabora.com" <daniel.almeida@collabora.com>,
John Hubbard <jhubbard@nvidia.com>,
"work@onurozkan.dev" <work@onurozkan.dev>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
"tamird@kernel.org" <tamird@kernel.org>,
Eliot Courtney <ecourtney@nvidia.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"gary@garyguo.net" <gary@garyguo.net>,
"dakr@kernel.org" <dakr@kernel.org>,
Alistair Popple <apopple@nvidia.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] gpu: nova: fix rust-analyzer generation
Date: Wed, 1 Jul 2026 18:39:43 +0000 [thread overview]
Message-ID: <433402bc0b73dd9bbe77496703c8e98f7525af45.camel@nvidia.com> (raw)
In-Reply-To: <20260701-nova-rust-analyzer-v1-1-5209f486f10d@nvidia.com>
On Wed, 2026-07-01 at 15:40 +0900, Alexandre Courbot wrote:
> The rust-analyzer generator script recognizes a crate when its
> corresponding `.o` appears in the Rust source file's immediate `Makefile`
> or `Kbuild` file.
>
> Commit ca524e273c43 ("gpu: build nova-core and nova-drm from
> drivers/gpu/Makefile") moves the build rules for `nova-core` and
> `nova-drm` into `drivers/gpu/Makefile`, which results in the generator
> script ignoring these crates.
>
> Fix this by naming the crates' module as a comment in their respective
> `Makefile`; this is enough for the script to pick them up and restore
> `rust-analyzer` functionality on them.
>
> Fixes: ca524e273c43 ("gpu: build nova-core and nova-drm from drivers/gpu/Makefile")
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Timur Tabi <ttabi@nvidia.com>
Thanks for fixing this bug so quickly. It was driving me crazy.
prev parent reply other threads:[~2026-07-01 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 6:40 [PATCH] gpu: nova: fix rust-analyzer generation Alexandre Courbot
2026-07-01 12:36 ` Onur Özkan
2026-07-02 1:09 ` Alexandre Courbot
2026-07-02 7:54 ` Miguel Ojeda
2026-07-01 18:39 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433402bc0b73dd9bbe77496703c8e98f7525af45.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox