Re: [PATCH] gpu: nova-core: use a single try_pin_init!() block in probe()

[John Hubbard <jhubbard@nvidia.com>]

On 9/28/26 6:48 AM, Danilo Krummrich wrote:
> On Mon Sep 28, 2026 at 2:23 AM CEST, Alexandre Courbot wrote:
>>> +        dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
>>
>> Don't you want to put this in the `_:` block below, so it printed at the
>> actual initialization time instead of the time the initializer is created?
> 
> No, because the :_ block below will become the PCI device enable guard soon. We
> could put it in a separate :_ block, but that seemed odd to me.
> 
> In any case, we probably should drop this dev_dbg!() entirely, as its value is
> quite limited.

I missed this comment until just now, when I went to test with the final
merged patch, and the "Probe..." debug print for each GPU was missing.

I really would like this restored. This is a high value thing to
print, because it acts as kind of a bookend, showing the beginning of
trying to boot up.

In fact, we even have some local scripts that look for it (not that
that matters, but just to indicate how we think about its usefulness).

I can post a trivial patch to restore it, if desired.

thanks,
-- 
John Hubbard