From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>
Cc: <aliceryhl@google.com>, <daniel.almeida@collabora.com>,
<ecourtney@nvidia.com>, <ojeda@kernel.org>, <boqun@kernel.org>,
<gary@garyguo.net>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>, <tmgross@umich.edu>,
<deborah.brouwer@collabora.com>, <boris.brezillon@collabora.com>,
<lyude@redhat.com>, <driver-core@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <nova-gpu@lists.linux.dev>,
<dri-devel@lists.freedesktop.org>,
<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v5 07/19] rust: drm: restrict AlwaysRefCounted to Normal GEM Object context
Date: Thu, 02 Jul 2026 13:38:30 +0900 [thread overview]
Message-ID: <DJNT3ASUG4FU.3IE0ARFHAVMIL@nvidia.com> (raw)
In-Reply-To: <20260628145406.2107056-8-dakr@kernel.org>
On Sun Jun 28, 2026 at 11:53 PM JST, Danilo Krummrich wrote:
> Restrict AlwaysRefCounted for gem::Object and gem::shmem::Object to the
> Normal context, since only Normal objects should be independently
> reference-counted.
>
> To avoid cascading through IntoGEMObject (which had AlwaysRefCounted as
> a supertrait), remove AlwaysRefCounted from IntoGEMObject's supertraits
> and instead add it as an explicit bound on lookup_handle(), which is the
> only BaseObject method that returns an ARef.
>
> Since Object::new() and shmem::Object::new() return ARef<Self>, move
> them to Normal-only impl blocks. Similarly, simplify ObjectConfig and
> shmem's parent_resv_obj field to the Normal context.
>
> Remove the DeviceContext generic from DriverObject::new() and
> Driver::Object, since GEM objects can only be constructed in the Normal
> context. Simplify DriverAllocImpl accordingly.
I think this last item could be its own patch - it wouldn't introduce
any extra churn, and would separate the concepts (restricting GEM
references to `Normal` context, and updating the API) nicely, making the
first patch a bit more focused (~+20/-35 LoCs extracted from it).
But even without this,
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
next prev parent reply other threads:[~2026-07-02 4:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 14:53 [PATCH v5 00/19] rust: drm: Higher-Ranked Lifetime private data Danilo Krummrich
2026-06-28 14:53 ` [PATCH v5 01/19] rust: drm: ioctl: fix unbounded lifetimes in ioctl handler arguments Danilo Krummrich
2026-06-29 21:32 ` lyude
2026-07-01 11:29 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 02/19] rust: drm: rename Uninit DeviceContext to Normal Danilo Krummrich
2026-07-01 11:29 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 03/19] rust: faux: add Device type with AsBusDevice support Danilo Krummrich
2026-07-01 11:30 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 04/19] rust: drm: Add Driver::ParentDevice associated type Danilo Krummrich
2026-07-01 11:30 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 05/19] rust: drm: change default DeviceContext to Normal Danilo Krummrich
2026-07-01 11:38 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 06/19] rust: drm: restrict AlwaysRefCounted to Normal Device context Danilo Krummrich
2026-07-01 11:39 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 07/19] rust: drm: restrict AlwaysRefCounted to Normal GEM Object context Danilo Krummrich
2026-07-02 4:38 ` Alexandre Courbot [this message]
2026-06-28 14:53 ` [PATCH v5 08/19] rust: drm/gem: remove DeviceContext from shmem::Object Danilo Krummrich
2026-06-29 21:35 ` lyude
2026-07-02 4:51 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 09/19] rust: drm: split Deref for Device context typestates Danilo Krummrich
2026-07-02 4:52 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 10/19] rust: drm: pin ioctl Device reference to Normal context Danilo Krummrich
2026-07-02 4:54 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 11/19] rust: drm: add Ioctl device context typestate Danilo Krummrich
2026-07-02 5:04 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 12/19] rust: drm: Add RegistrationGuard for drm_dev_enter/exit critical sections Danilo Krummrich
2026-07-02 6:06 ` Alexandre Courbot
2026-07-02 6:33 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 13/19] rust: drm: Wrap ioctl dispatch in RegistrationGuard Danilo Krummrich
2026-07-02 6:36 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 14/19] rust: drm: return ParentDevice from Device AsRef Danilo Krummrich
2026-07-02 6:39 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 15/19] rust: drm: add AsRef<ParentDevice<Bound>> for Device<Registered> Danilo Krummrich
2026-07-02 6:43 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 16/19] drm: fix race between partial drm_dev_register() failure and ioctl Danilo Krummrich
2026-06-29 21:37 ` lyude
2026-07-02 6:48 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 17/19] rust: drm: Add RegistrationData to drm::Driver Danilo Krummrich
2026-07-02 7:18 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 18/19] rust: drm: Pass registration data to ioctl handlers Danilo Krummrich
2026-07-02 7:22 ` Alexandre Courbot
2026-06-28 14:53 ` [PATCH v5 19/19] drm: nova: Use drm::Device<Registered> to access the parent bus device Danilo Krummrich
2026-07-02 7:29 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJNT3ASUG4FU.3IE0ARFHAVMIL@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=deborah.brouwer@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox