Re: [PATCH 2/4] gpu: nova: Add DRM registration data

["Danilo Krummrich" <dakr@kernel.org>]

On Mon Jul 6, 2026 at 7:34 AM CEST, Alistair Popple wrote:
> diff --git a/drivers/gpu/drm/nova/file.rs b/drivers/gpu/drm/nova/file.rs
> index 298c02bacb4b..855b6ffe696f 100644
> --- a/drivers/gpu/drm/nova/file.rs
> +++ b/drivers/gpu/drm/nova/file.rs
> @@ -1,11 +1,10 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
> -use crate::driver::{NovaDevice, NovaDriver};
> +use crate::driver::{DrmRegData, NovaDevice, NovaDriver};

Please switch to vertical import style.

>  use crate::gem::NovaObject;
>  use kernel::{
>      alloc::flags::*,
>      auxiliary,
> -    device::Bound,
>      drm::{
>          self,
>          gem::BaseObject,
> @@ -30,12 +29,12 @@ impl File {
>      /// IOCTL: get_param: Query GPU / driver metadata.
>      pub(crate) fn get_param(
>          dev: &NovaDevice<Registered>,
> -        _reg_data: &(),
> +        _reg_data: &DrmRegData<'_>,
>          getparam: &mut uapi::drm_nova_getparam,
>          _file: &drm::File<File>,
>      ) -> Result<u32> {
> -        let adev: &auxiliary::Device<Bound> = dev.as_ref();
> -        let pdev: &pci::Device<Bound> = adev.parent().try_into()?;
> +        let adev: &auxiliary::Device<_> = dev.as_ref();
> +        let pdev: &pci::Device<_> = adev.parent().try_into()?;

Nothing for this patch, but now that we can call into nova-core we can obtain
the information from the pci::Device via NovaCoreApi.

The advantage is that NovaCoreApi can store the pci::Device<Bound> from
nova-core directly, i.e. we get rid of the try_into() dance to obtain the
correct parent device type.

Subsequently, we can remove this TryInto impl entirely. :)