NVIDIA GPU driver infrastructure
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Timur Tabi" <ttabi@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Russ Weight" <russ.weight@linux.dev>,
	<rust-for-linux@vger.kernel.org>, <driver-core@lists.linux.dev>,
	"Gary Guo" <gary@garyguo.net>, <nova-gpu@lists.linux.dev>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Zhi Wang" <zhiw@nvidia.com>
Subject: Re: [PATCH v5 1/8] rust: alloc: add Vec::zeroed method
Date: Mon, 27 Jul 2026 17:06:08 +0900	[thread overview]
Message-ID: <DK975WCPTEKC.PL6U1OJHUMXD@nvidia.com> (raw)
In-Reply-To: <20260710230428.865447-2-ttabi@nvidia.com>

On Sat Jul 11, 2026 at 8:04 AM JST, Timur Tabi wrote:
> Add a constructor for kernel Vec that allocates a vector of a given length
> with all elements zero-initialized. Memory is allocated with the __GFP_ZERO
> flag, matching the existing KBox::zeroed() pattern.
>
> Signed-off-by: Timur Tabi <ttabi@nvidia.com>
> ---
>  rust/kernel/alloc/kvec.rs | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs
> index f7af62835aa8..4ca589919c1c 100644
> --- a/rust/kernel/alloc/kvec.rs
> +++ b/rust/kernel/alloc/kvec.rs
> @@ -9,6 +9,7 @@
>          Vmalloc,
>          VmallocPageIter, //
>      },
> +    flags::__GFP_ZERO,
>      layout::ArrayLayout,
>      AllocError,
>      Allocator,
> @@ -51,6 +52,8 @@
>      }, //
>  };
>  
> +use pin_init::Zeroable;
> +
>  mod errors;
>  pub use self::errors::{InsertError, PushError, RemoveError};
>  
> @@ -532,6 +535,23 @@ pub fn with_capacity(capacity: usize, flags: Flags) -> Result<Self, AllocError>
>          Ok(v)
>      }
>  
> +    /// Creates a new [`Vec`] with `n` zero-initialized elements.
> +    ///
> +    /// New memory is allocated with `A` and the [`__GFP_ZERO`] flag.

Every other method I've looked at has an `# Examples` paragraph in its
doccomment, can you add a short example to this one as well?

With this, and Miguel's comment taken into account:

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

  parent reply	other threads:[~2026-07-27  8:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 23:04 [PATCH v5 0/8] Transition Nova Core to TLV firmare images Timur Tabi
2026-07-10 23:04 ` [PATCH v5 1/8] rust: alloc: add Vec::zeroed method Timur Tabi
2026-07-11 13:25   ` Miguel Ojeda
2026-07-13  2:21     ` Timur Tabi
2026-07-27  8:06   ` Alexandre Courbot [this message]
2026-07-10 23:04 ` [PATCH v5 2/8] rust: firmware: add request_into_buf() Timur Tabi
2026-07-27  8:06   ` Alexandre Courbot
2026-07-27 10:38   ` Alexandre Courbot
2026-07-10 23:04 ` [PATCH v5 3/8] gpu: nova-core: add TLV parser for firmware files Timur Tabi
2026-07-27 11:31   ` Alexandre Courbot
2026-07-10 23:04 ` [PATCH v5 4/8] gpu: nova-core: transition booter_load to TLV images Timur Tabi
2026-07-10 23:04 ` [PATCH v5 5/8] gpu: nova-core: transition gsp " Timur Tabi
2026-07-27 11:29   ` Alexandre Courbot
2026-07-10 23:04 ` [PATCH v5 6/8] gpu: nova-core: transition gen_bootloader " Timur Tabi
2026-07-10 23:04 ` [PATCH v5 7/8] gpu: nova-core: transition fsp " Timur Tabi
2026-07-10 23:04 ` [PATCH v5 8/8] gpu: nova-core: update firmware module info for " Timur Tabi
2026-07-27  8:06   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DK975WCPTEKC.PL6U1OJHUMXD@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=mcgrof@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox