From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 400B6CA4E; Wed, 8 Jul 2026 14:38:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521513; cv=pass; b=HXH60n9hl5CUZtLXi45MpSUobi/no++Ywg+TEjuRbQf9cWc4H9mgKcrtAhxlT/AM9767rI9qLhvi08x8f7JIRy/j0TWldRz/YINMZ/5hDTAKKwS4TrdB9/KK43jn8sJLNZHfcCz530XZ+mDV5QWhmxuDuKxogZ/cRyLitKuozqc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521513; c=relaxed/simple; bh=LS3Er9/rUJO4Uq0PFkYQ5J0m8lSbFGIMaWRGsJ5V5j8=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=tcYheqky+6x9N+BfrLbFqXHaP9uqT8q9Vd/RQ9e637iEo+n9wyhkOR/03no0/0AGZb9WHlbABrwxwbCK0fLJkl+Q2yy48PzWVupcDGdVwaw28R0BteW/jbps2Nd9Ix+SLWckeyzzbkaJLxIPDPbeioarpChsRBnKQXR9nEqKqF0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=f6SQ6ozR; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="f6SQ6ozR" ARC-Seal: i=1; a=rsa-sha256; t=1783521497; cv=none; d=zohomail.com; s=zohoarc; b=YI9KLNSqgyAoa9aM0cAmQldkCgz+KrFLJRASnXJQROPxfYRP23SbxOpE6MeJyV+l1vz1VD1nktiIXdBZwvteyJzUOaZx9DWqBF1atBX+7tCIHNVYV3hYMhO6M646K+iEzEOpb6Sti3pRlJOEJIB903Q3Z60OeJhP5nP1n8uWuKA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783521497; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Dz9e3DzXA9jmsTd/AXX4tRzwMh81Cxl6isVCCv3t7Pw=; b=hVaBJbC3/bVUjDT9Aa+qm37WLClM65VhFxRHZweepi/UqlFOM+xKDDarhVOJ4n0TMjzXm99cVLLk438zcVQ/igSi1dbQPdPOprXEckXY/+awKIeWl0zATfThI2Kt7fbMRT8veL8vD0ZQt/6mjwVFVap7+IY4hkMpjx5UEKXESL8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1783521497; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=Dz9e3DzXA9jmsTd/AXX4tRzwMh81Cxl6isVCCv3t7Pw=; b=f6SQ6ozR7FZO4RAo5W+scxh4D3hMm20YJG1+8gvebA7kW5e2C4DHiOh6dQO8UGzm tGf+4H4A27OfSG/b/6uoEYwYIACXfch3KwR5rJmXufWILrNXF1o6gM58U/dONIPBg+v kTc3hjEw33xHfh9ZM3MZkm7/CrRl3/MclcWmeFOI= Received: by mx.zohomail.com with SMTPS id 1783521495227502.89899039827594; Wed, 8 Jul 2026 07:38:15 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: nova-gpu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH v6 10/20] pwm: th1520: remove unnecessary `deref` From: Daniel Almeida In-Reply-To: <20260706-io_projection-v6-10-72cd5d055d54@garyguo.net> Date: Wed, 8 Jul 2026 11:37:55 -0300 Cc: Alice Ryhl , Greg Kroah-Hartman , "Rafael J. Wysocki" , Miguel Ojeda , Boqun Feng , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Tamir Duberstein , =?utf-8?Q?Onur_=C3=96zkan?= , Bjorn Helgaas , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , Abdiel Janulgue , Robin Murphy , Alexandre Courbot , David Airlie , Simona Vetter , Michal Wilczynski , =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= , Danilo Krummrich , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, nova-gpu@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-pwm@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260706-io_projection-v6-0-72cd5d055d54@garyguo.net> <20260706-io_projection-v6-10-72cd5d055d54@garyguo.net> To: Gary Guo X-Mailer: Apple Mail (2.3826.700.81) X-ZohoMailClient: External > On 6 Jul 2026, at 09:44, Gary Guo wrote: >=20 > `Deref` is automatic and should normally not be used directly. > Also, `IoMem` is going to be implementing `Io` directly, so it will no > longer to be implementing `Deref`. >=20 > Reported-by: Andreas Hindborg > Link: = https://rust-for-linux.zulipchat.com/#narrow/channel/291565-Help/topic/.E2= .9C.94.20Projection.20in.20dma.20bus.20address.20space/near/606672061 > Reviewed-by: Alexandre Courbot > Signed-off-by: Gary Guo > --- > drivers/pwm/pwm_th1520.rs | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs > index 3e3fa51ccef9..022338d17218 100644 > --- a/drivers/pwm/pwm_th1520.rs > +++ b/drivers/pwm/pwm_th1520.rs > @@ -20,7 +20,6 @@ > //! this method is not used in this driver. > //! >=20 > -use core::ops::Deref; > use kernel::{ > clk::Clk, > device::{Bound, Core, Device}, > @@ -213,8 +212,7 @@ fn read_waveform( > ) -> Result { > let data =3D chip.drvdata(); > let hwpwm =3D pwm.hwpwm(); > - let iomem_accessor =3D data.iomem.access(parent_dev)?; > - let iomap =3D iomem_accessor.deref(); > + let iomap =3D data.iomem.access(parent_dev)?; >=20 > let ctrl =3D iomap.try_read32(th1520_pwm_ctrl(hwpwm))?; > let period_cycles =3D = iomap.try_read32(th1520_pwm_per(hwpwm))?; > @@ -248,8 +246,7 @@ fn write_waveform( > ) -> Result { > let data =3D chip.drvdata(); > let hwpwm =3D pwm.hwpwm(); > - let iomem_accessor =3D data.iomem.access(parent_dev)?; > - let iomap =3D iomem_accessor.deref(); > + let iomap =3D data.iomem.access(parent_dev)?; > let duty_cycles =3D iomap.try_read32(th1520_pwm_fp(hwpwm))?; > let was_enabled =3D duty_cycles !=3D 0; >=20 >=20 > --=20 > 2.54.0 >=20 Reviewed-by: Daniel Almeida