Re: [PATCH v2 06/12] rust: io: register: implement Copy and Clone for RegisterArrayLoc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] rust: io: register: missing #[inline] on
  RegisterArrayLoc::clone()
--

commit bf14039e845ff1b0df72a205d4992beb78cd56a0
Author: Alexandre Courbot <acourbot@nvidia.com>

rust: io: register: implement Copy and Clone for RegisterArrayLoc

This commit implements Clone and Copy for RegisterArrayLoc<T> so a
validated register array location can be reused across multiple I/O
accesses.

> diff --git a/rust/kernel/io/register.rs b/rust/kernel/io/register.rs
> index b6513fa0f412c..9e31e68d02cde 100644
> --- a/rust/kernel/io/register.rs
> +++ b/rust/kernel/io/register.rs
> @@ -194,6 +194,14 @@ pub fn try_new(idx: usize) -> Option<Self> {
>      }
>  }
>  
> +impl<T: RegisterArray> Clone for RegisterArrayLoc<T> {
> +    fn clone(&self) -> Self {
> +        *self
> +    }
> +}

[Severity: Low]
Should RegisterArrayLoc::clone() be marked #[inline], matching the rest of
the kernel crate abstractions and the other functions in this file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-r000-fw-v2-0-fb37cc5b20cd@nvidia.com?part=6