RE: [PATCH 2/2] NTB: Remove _addr functions from ntb_hw_amd

["Allen Hubbe" <Allen.Hubbe@emc.com>]

> From: Yu, Xiangliang
> > From: Allen Hubbe
> > > From: Yu, Xiangliang
> > > > From: Allen Hubbe
> > > > Kernel zero day testing warned about address space confusion.  A
> > > > virtual iomem address was used where a physical address is expected.
> > > > The offending functions implement an optional part of the api, so
> > > > they are removed.  They can be added later, after testing.
> > >
> > > Ntb_dev_ops_is_valid will check the related implement and AMD ntb
> > > driver can't Register ntb device if you remove the two functions.
> >
> > See [PATCH 1/2].
> 
> I haven't received the mail of [PATCH 1/2].

I resent it just to you.  Are you not subscribed to the linux-ntb mailing list?

Note: this patch 2/2 just takes the _addr functions out of the driver, which is the only change I am comfortable to make without testing.  Since I cannot test the driver, I cannot provide any real fix for the functions.  Since you have the ability to test, if you provide a fix for these functions, I expect your patch would be accepted instead of this one.  If you provide a fix, it would be best to provide that fix assuming that my patch has not been applied, so that your changes for the fix are clear in the patch.