From: "Allen Hubbe" <Allen.Hubbe@dell.com>
To: 'Shyam Sundar S K' <ssundark@amd.com>,
'Jon Mason' <jdmason@kudzu.us>,
'Dave Jiang' <dave.jiang@intel.com>
Cc: "'Yu, Xiangliang'" <Xiangliang.Yu@amd.com>,
"'Shah, Nehal-bakulchandra'" <Nehal-bakulchandra.Shah@amd.com>,
"'Agrawal, Nitesh-kumar'" <Nitesh-kumar.Agrawal@amd.com>,
"'Sen, Pankaj'" <Pankaj.Sen@amd.com>,
"'Su, Richard (Bin)'" <Richard1.Su@amd.com>,
"'Subramaniyan, Ramkumar'" <ramkumar.ks@amd.com>,
linux-ntb@googlegroups.com
Subject: RE: [PATCH 1/2] ntb_transport: Limit memory windows based on available, scratchpads
Date: Fri, 2 Dec 2016 09:30:07 -0500 [thread overview]
Message-ID: <000001d24ca8$955380a0$bffa81e0$@dell.com> (raw)
In-Reply-To: <7e2a1e3b-607a-197e-f965-e26cd3a4af60@amd.com>
From: Shyam Sundar S K
> Do you feel this part of the code is required in ntb_transport_probe() ?
>
> if (ntb_spad_count(ndev) < (NUM_MWS + 1 + mw_count * 2)) {
> dev_err(&ndev->dev, "Not enough scratch pad registers for %s",
> NTB_TRANSPORT_NAME);
> return -EIO;
> }
>
> Because in case of AMD, this condition will always fail.
You're right. That check can be removed with the addition of your other changes.
next prev parent reply other threads:[~2016-12-02 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 19:11 [PATCH 1/2] ntb_transport: Limit memory windows based on available, scratchpads Shyam Sundar S K
2016-12-02 2:22 ` Allen Hubbe
2016-12-02 12:32 ` Shyam Sundar S K
2016-12-02 14:30 ` Allen Hubbe [this message]
2016-12-02 16:31 ` Shyam Sundar S K
2016-12-02 16:57 ` Allen Hubbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d24ca8$955380a0$bffa81e0$@dell.com' \
--to=allen.hubbe@dell.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Nitesh-kumar.Agrawal@amd.com \
--cc=Pankaj.Sen@amd.com \
--cc=Richard1.Su@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-ntb@googlegroups.com \
--cc=ramkumar.ks@amd.com \
--cc=ssundark@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox