From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com. [2a00:1450:4864:20::52a]) by gmr-mx.google.com with ESMTPS id o17si600687wrp.4.2021.07.06.04.42.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 04:42:35 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id y40so12436403ede.4 for ; Tue, 06 Jul 2021 04:42:35 -0700 (PDT) Return-Path: Subject: Re: [PATCH] bus: Make remove callback return void References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> From: Maximilian Luz Message-ID: <07c08230-6c71-2a73-c89f-05b9b5de78ab@gmail.com> Date: Tue, 6 Jul 2021 13:42:31 +0200 MIME-Version: 1.0 In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Maxime Ripard , Jiri Kosina , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Johannes Thumshirn , Mauro Carvalho Chehab , Arnd Bergmann , Jakub Kicinski , "David S. Miller" , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Hans de Goede , Mark Gross , Bjorn Andersson , Andy Gross , Mark Brown , Stephen Boyd , Johan Hovold , Alex Elder , Mika Westerberg , Rob Herring , Jiri Slaby , Stefano Stabellini , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Adrian Hunter , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, linux-wireless@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev, dmaengine@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-fpga@vger.kernel.org, linux-input@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, industrypack-devel@lists.sourceforge.net, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, greybus-dev@lists.linaro.org, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org List-ID: On 7/6/21 11:50 AM, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König > drivers/platform/surface/aggregator/bus.c | 4 +--- Acked-by: Maximilian Luz