Re: [PATCH 0/2] NTB: Stash private data in transport client device

[Aaron Sierra <asierra@xes-inc.com>]

----- Original Message -----
> From: "Allen Hubbe" <allenbh@gmail.com>
> Sent: Monday, October 15, 2018 9:59:28 AM

> On Fri, Oct 12, 2018 at 4:20 PM Aaron Sierra <asierra@xes-inc.com> wrote:
>>
>> Support NTB transport client device drivers stashing a reference to
>> their private device representation within the transport client device
>> for trivial lookup.
> 
> Can dev_get/set_drvdata() be used instead?

Allen, sure that would work just fine. You're asking for dev_get_drvdata
and dev_set_drvdata to be used behind-the-scenes as an implementation
detail, right?
 
>> Use the new stashing mechanism to simplify ntb_netdev device probe
>> and remove. This optimization will also benefit any out-of-tree
>> drivers that care to use it.
> 
> Simplify ntb_netdev_remove() looks good.  Please also set(NULL) on remove.

I'd like to add this cleanup as a call to ntb_transport_client_set_pdata()
in ntb_transport_client_release(), so all transport client drivers get it for
free if that's alright with you.

-Aaron S.

>>
>> Aaron Sierra (2):
>>   NTB: transport: Support client device private data
>>   ntb_netdev: Simplify remove with client private data
>>
>>  drivers/net/ntb_netdev.c      | 28 +++-------------------------
>>  drivers/ntb/ntb_transport.c   | 19 +++++++++++++++++++
>>  include/linux/ntb_transport.h |  2 ++
>>  3 files changed, 24 insertions(+), 25 deletions(-)
>>
>> --
>> 2.7.4