From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pebolle@tiscali.nl>
Received: from lb2-smtp-cloud6.xs4all.net (lb2-smtp-cloud6.xs4all.net. [194.109.24.28])
        by gmr-mx.google.com with ESMTPS id m3si46658wia.1.2015.05.21.01.54.37
        for <linux-ntb@googlegroups.com>
        (version=TLSv1 cipher=RC4-SHA bits=128/128);
        Thu, 21 May 2015 01:54:37 -0700 (PDT)
Message-ID: <1432198475.21715.137.camel@x220>
Subject: Re: [PATCH 06/16] NTB Pingpong Client
From: Paul Bolle <pebolle@tiscali.nl>
Date: Thu, 21 May 2015 10:54:35 +0200
In-Reply-To: <c708a1b50b8137556fb327c313184855aeaf54e3.1432135632.git.Allen.Hubbe@emc.com>
References: <cover.1432135631.git.Allen.Hubbe@emc.com>
	 <c708a1b50b8137556fb327c313184855aeaf54e3.1432135632.git.Allen.Hubbe@emc.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
To: Allen Hubbe <Allen.Hubbe@emc.com>
Cc: linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>
List-ID: <linux-ntb.googlegroups.com>

Similar nit as for 2/6.

On Wed, 2015-05-20 at 11:41 -0400, Allen Hubbe wrote:
> --- a/drivers/ntb/Kconfig
> +++ b/drivers/ntb/Kconfig
> @@ -14,6 +14,8 @@ if NTB
>  
>  source "drivers/ntb/hw/Kconfig"
>  
> +source "drivers/ntb/test/Kconfig"
> +
>  config NTB_TRANSPORT

> --- /dev/null
> +++ b/drivers/ntb/test/Kconfig

> +config NTB_PINGPONG
> +       tristate "NTB Simple Ping Pong Client"
> +       depends on NTB

Again, superfluous dependency.

> +       help
> +        This is a simple ping pong driver that exercises the scratchpads and
> +        doorbells of the ntb hardware.  This driver may be used to test that
> +        your ntb hardware and drivers are functioning at a basic level.
> +
> +        If unsure, say N.

Thanks,


Paul Bolle