Re: [PATCH] NTB: Clear property bits in BAR value

["Jiang, Dave" <dave.jiang@intel.com>]

On Thu, 2015-11-19 at 12:50 -0800, Conrad Meyer wrote:
> Looks fine to me.  Isn't unsigned long 64 bits on Linux amd64?
> (Should NTB_BAR_MASK_32 just be ~(0xfu)?)

Good catch! I'll fix that. 

> 
> Best,
> Conrad
> 
> On Thu, Nov 19, 2015 at 12:47 PM, Dave Jiang <dave.jiang@intel.com>
> wrote:
> > The lower bits read from a BAR register will contain property bits
> > that we do not care about. Clear those so that we can use the BAR
> > values for limit and xlat registers.
> > 
> > Reported-by: Conrad Meyer <cem@freebsd.org>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > ---
> >  drivers/ntb/hw/intel/ntb_hw_intel.c |    4 ++--
> >  drivers/ntb/hw/intel/ntb_hw_intel.h |    3 +++
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c
> > b/drivers/ntb/hw/intel/ntb_hw_intel.c
> > index a198f82..40d04ef 100644
> > --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> > +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> > @@ -875,7 +875,7 @@ static int intel_ntb_mw_set_trans(struct
> > ntb_dev *ntb, int idx,
> >         limit_reg = bar2_off(ndev->xlat_reg->bar2_limit, bar);
> > 
> >         if (bar < 4 || !ndev->bar4_split) {
> > -               base = ioread64(mmio + base_reg);
> > +               base = ioread64(mmio + base_reg) & NTB_BAR_MASK_64;
> > 
> >                 /* Set the limit if supported, if size is not
> > mw_size */
> >                 if (limit_reg && size != mw_size)
> > @@ -906,7 +906,7 @@ static int intel_ntb_mw_set_trans(struct
> > ntb_dev *ntb, int idx,
> >                 if ((addr + size) & (~0ull << 32))
> >                         return -EINVAL;
> > 
> > -               base = ioread32(mmio + base_reg);
> > +               base = ioread32(mmio + base_reg) & NTB_BAR_MASK_32;
> > 
> >                 /* Set the limit if supported, if size is not
> > mw_size */
> >                 if (limit_reg && size != mw_size)
> > diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.h
> > b/drivers/ntb/hw/intel/ntb_hw_intel.h
> > index 2eb4add..a257c7c 100644
> > --- a/drivers/ntb/hw/intel/ntb_hw_intel.h
> > +++ b/drivers/ntb/hw/intel/ntb_hw_intel.h
> > @@ -245,6 +245,9 @@
> >  #define NTB_UNSAFE_DB                  BIT_ULL(0)
> >  #define NTB_UNSAFE_SPAD                        BIT_ULL(1)
> > 
> > +#define NTB_BAR_MASK_64                        ~(0xfull)
> > +#define NTB_BAR_MASK_32                        ~(0xful)
> > +
> >  struct intel_ntb_dev;
> > 
> >  struct intel_ntb_reg {
> > 
>