Linux PCI Non-Transparent Bridge framework and drivers
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: Allen Hubbe <Allen.Hubbe@emc.com>
Cc: 'Dave Jiang' <dave.jiang@intel.com>, linux-ntb@googlegroups.com
Subject: Re: [PATCH] ntb: ntb_hw_intel: init peer_addr in struct intel_ntb_dev
Date: Tue, 1 Nov 2016 16:33:31 -0400	[thread overview]
Message-ID: <20161101203330.GA25928@kudzu.us> (raw)
In-Reply-To: <000101d1fe53$8112f920$8338eb60$@emc.com>

On Wed, Aug 24, 2016 at 06:04:36PM -0400, Allen Hubbe wrote:
> From: Dave Jiang
> > The peer_addr member of intel_ntb_dev is not set, therefore when
> > acquiring ntb_peer_db and ntb_peer_spad we only get the offset rather
> > than the actual physical address. Adding fix to correct that.
> > 
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> 
> Acked-by: Allen Hubbe <Allen.Hubbe@emc.com>

Sorry for missing this one.  In my tree now.

Thanks,
Jon

> 
> > ---
> >  drivers/ntb/hw/intel/ntb_hw_intel.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> > index 40d04ef..3ad1f15 100644
> > --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> > +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> > @@ -1718,6 +1718,8 @@ static int xeon_setup_b2b_mw(struct intel_ntb_dev *ndev,
> >  					    XEON_B2B_MIN_SIZE);
> >  		if (!ndev->peer_mmio)
> >  			return -EIO;
> > +
> > +		ndev->peer_addr = pci_resource_start(pdev, b2b_bar);
> >  	}
> > 
> >  	return 0;
> > @@ -1982,6 +1984,7 @@ static int intel_ntb_init_pci(struct intel_ntb_dev *ndev, struct
> > pci_dev *pdev)
> >  		goto err_mmio;
> >  	}
> >  	ndev->peer_mmio = ndev->self_mmio;
> > +	ndev->peer_addr = pci_resource_start(pdev, 0);
> > 
> >  	return 0;
> > 
> 
> 

  reply	other threads:[~2016-11-01 20:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 21:16 [PATCH] ntb: ntb_hw_intel: init peer_addr in struct intel_ntb_dev Dave Jiang
2016-08-24 22:04 ` Allen Hubbe
2016-11-01 20:33   ` Jon Mason [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-27 18:06 Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101203330.GA25928@kudzu.us \
    --to=jdmason@kudzu.us \
    --cc=Allen.Hubbe@emc.com \
    --cc=dave.jiang@intel.com \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox