Re: [PATCH] NTB: ntb_transport: fix debugfs_remove_recursive

[Jon Mason <jdmason@kudzu.us>]

On Tue, Dec 27, 2016 at 05:57:04PM -0500, Allen Hubbe wrote:
> The call to debugfs_remove_recursive(qp->debugfs_dir) of the sub-level
> directory must not be later than
> debugfs_remove_recursive(nt_debugfs_dir) of the top-level directory.
> Otherwise, the sub-level directory will not exist, and it would be
> invalid (panic) to attempt to remove it.  This removes the top-level
> directory last, after sub-level directories have been cleaned up.
> 
> Signed-off-by: Allen Hubbe <Allen.Hubbe@dell.com>

Applied to my ntb tree

Thanks,
Jon

> ---
>  drivers/ntb/ntb_transport.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index f81aa4b18d9f..0e18adb51e4e 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -2273,9 +2273,8 @@ module_init(ntb_transport_init);
>  
>  static void __exit ntb_transport_exit(void)
>  {
> -	debugfs_remove_recursive(nt_debugfs_dir);
> -
>  	ntb_unregister_client(&ntb_transport_client);
>  	bus_unregister(&ntb_transport_bus);
> +	debugfs_remove_recursive(nt_debugfs_dir);
>  }
>  module_exit(ntb_transport_exit);
> -- 
> 2.9.1
>