Re: [PATCH] ntb: ntb_perf missing dmaengine_unmap_put

[Jon Mason <jdmason@kudzu.us>]

On Mon, Jan 30, 2017 at 02:21:17PM -0700, Dave Jiang wrote:
> In the normal I/O execution path, ntb_perf is missing a call to
> dmaengine_unmap_put() after submission. That causes us to leak
> unmap objects.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>

Looks good to me.  Pulled into my ntb branch.

Given that this is a bug fix, we should probably start following the
new-ish standard of adding a "Fixes: " to this.  I'll add this one by
hand.  I believe it should be:

Fixes: 8a7b6a77 ("ntb: ntb perf tool")

Thanks,
Jon

> ---
>  drivers/ntb/test/ntb_perf.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index e75d4fd..434e1d4 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -265,6 +265,8 @@ static ssize_t perf_copy(struct pthr_ctx *pctx, char __iomem *dst,
>  	if (dma_submit_error(cookie))
>  		goto err_set_unmap;
>  
> +	dmaengine_unmap_put(unmap);
> +
>  	atomic_inc(&pctx->dma_sync);
>  	dma_async_issue_pending(chan);
>  
>