From: Jon Mason <jdmason@kudzu.us>
To: Allen Hubbe <Allen.Hubbe@dell.com>
Cc: 'Aaron Sierra' <asierra@xes-inc.com>,
'Dave Jiang' <dave.jiang@intel.com>,
linux-ntb@googlegroups.com,
'Thomas Vanselus' <tvanselus@xes-inc.com>
Subject: Re: ntb_transport: Pick an unused queue
Date: Thu, 16 Feb 2017 20:14:05 -0500 [thread overview]
Message-ID: <20170217011405.GB1207@kudzu.us> (raw)
In-Reply-To: <000001d286cd$6d62e0e0$4828a2a0$@dell.com>
On Tue, Feb 14, 2017 at 09:20:00AM -0500, Allen Hubbe wrote:
> From: Aaron Sierra
> > From: Thomas VanSelus <tvanselus@xes-inc.com>
> >
> > Fix typo causing ntb_transport_create_queue to select the first
> > queue every time, instead of using the next free queue.
> >
> > Signed-off-by: Thomas VanSelus <tvanselus@xes-inc.com>
> > Signed-off-by: Aaron Sierra <asierra@xes-inc.com>
>
> Acked-by: Allen Hubbe <Allen.Hubbe@dell.com>
Good catch! This has been in there from the beginning.
Add a
Fixes: fce8a7bb5 ("PCI-Express Non-Transparent Bridge Support")
and applied to my ntb branch.
Thanks,
Jon
>
> > ---
> > drivers/ntb/ntb_transport.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> > index f81aa4b..95b5540 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
> >
> > node = dev_to_node(&ndev->dev);
> >
> > - free_queue = ffs(nt->qp_bitmap);
> > + free_queue = ffs(nt->qp_bitmap_free);
> > if (!free_queue)
> > goto err;
> >
>
prev parent reply other threads:[~2017-02-17 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 22:46 [PATCH] ntb_transport: Pick an unused queue Aaron Sierra
2017-02-14 14:20 ` Allen Hubbe
2017-02-17 1:14 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217011405.GB1207@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Allen.Hubbe@dell.com \
--cc=asierra@xes-inc.com \
--cc=dave.jiang@intel.com \
--cc=linux-ntb@googlegroups.com \
--cc=tvanselus@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox