Linux PCI Non-Transparent Bridge framework and drivers
 help / color / mirror / Atom feed
From: Jon Mason <jdmason@kudzu.us>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Gary R Hook <gary.hook@amd.com>,
	linux-ntb@googlegroups.com, Allen.Hubbe@emc.com
Subject: Re: [PATCH] ntb: Correct modinfo usage statement for ntb_perf
Date: Fri, 9 Jun 2017 16:33:15 -0400	[thread overview]
Message-ID: <20170609203315.GA9847@kudzu.us> (raw)
In-Reply-To: <c8b3198e-e38a-05a4-fa31-a8d074888f01@intel.com>

On Thu, May 04, 2017 at 09:47:44AM -0700, Dave Jiang wrote:
> 
> 
> On 05/04/2017 09:36 AM, Gary R Hook wrote:
> > The order parameters are powers of 2; adjust the usage information
> > to use correct mathematical representations.
> > 
> > Signed-off-by: Gary R Hook <gary.hook@amd.com>
> Acked-by: Dave Jiang <dave.jiang@intel.com>

Sorry, I think I missed this one.  Adding to my ntb branch with the
following line

Fixes: 8a7b6a778a85 ("ntb: ntb perf tool")

This enables the stable kernels it is a bug fix and to pick it up.

> 
> > ---
> >  drivers/ntb/test/ntb_perf.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index 9c4a21f1a9d9..42756a98a728 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -91,11 +91,11 @@
> >  
> >  static unsigned int seg_order = 19; /* 512K */
> >  module_param(seg_order, uint, 0644);
> > -MODULE_PARM_DESC(seg_order, "size order [n^2] of buffer segment for testing");
> > +MODULE_PARM_DESC(seg_order, "size order [2^n] of buffer segment for testing");
> >  
> >  static unsigned int run_order = 32; /* 4G */
> >  module_param(run_order, uint, 0644);
> > -MODULE_PARM_DESC(run_order, "size order [n^2] of total data to transfer");
> > +MODULE_PARM_DESC(run_order, "size order [2^n] of total data to transfer");
> >  
> >  static bool use_dma; /* default to 0 */
> >  module_param(use_dma, bool, 0644);
> > 

      reply	other threads:[~2017-06-09 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 16:36 [PATCH] ntb: Correct modinfo usage statement for ntb_perf Gary R Hook
2017-05-04 16:47 ` Dave Jiang
2017-06-09 20:33   ` Jon Mason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170609203315.GA9847@kudzu.us \
    --to=jdmason@kudzu.us \
    --cc=Allen.Hubbe@emc.com \
    --cc=dave.jiang@intel.com \
    --cc=gary.hook@amd.com \
    --cc=linux-ntb@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox