From: kbuild test robot <lkp@intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: kbuild-all@01.org, jdmason@kudzu.us, dave.jiang@intel.com,
Allen.Hubbe@emc.com, Shyam-sundar.S-k@amd.com,
Xiangliang.Yu@amd.com, Sergey.Semin@t-platforms.ru,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support
Date: Mon, 4 Dec 2017 01:58:25 +0800 [thread overview]
Message-ID: <201712040133.bmgRyXdj%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171130213809.20984-1-fancer.lancer@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6729 bytes --]
Hi Serge,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v4.15-rc1]
[cannot apply to ntb/ntb-next next-20171201]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Serge-Semin/NTB-ntb_perf-Add-full-multi-port-NTB-API-support/20171204-011126
config: parisc-allmodconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=parisc
All warnings (new ones prefixed by >>):
drivers/ntb//test/ntb_perf.c: In function 'perf_msg_cmd_send':
drivers/ntb//test/ntb_perf.c:375:3: error: implicit declaration of function 'ntb_peer_msg_write'; did you mean 'ntb_peer_spad_write'? [-Werror=implicit-function-declaration]
ntb_peer_msg_write(perf->ntb, peer->pidx, PERF_MSG_LDATA,
^~~~~~~~~~~~~~~~~~
ntb_peer_spad_write
drivers/ntb//test/ntb_perf.c: In function 'perf_msg_cmd_recv':
drivers/ntb//test/ntb_perf.c:408:32: warning: passing argument 2 of 'ntb_msg_read' makes integer from pointer without a cast [-Wint-conversion]
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_CMD);
^~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int' but argument is of type 'int *'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:408:8: error: too few arguments to function 'ntb_msg_read'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_CMD);
^~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: declared here
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:411:32: warning: passing argument 2 of 'ntb_msg_read' makes integer from pointer without a cast [-Wint-conversion]
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_LDATA);
^~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int' but argument is of type 'int *'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:229:25: warning: passing argument 3 of 'ntb_msg_read' makes pointer from integer without a cast [-Wint-conversion]
#define PERF_MSG_LDATA 1
^
drivers/ntb//test/ntb_perf.c:411:38: note: in expansion of macro 'PERF_MSG_LDATA'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_LDATA);
^~~~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int *' but argument is of type 'int'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:411:8: error: too few arguments to function 'ntb_msg_read'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_LDATA);
^~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: declared here
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:414:32: warning: passing argument 2 of 'ntb_msg_read' makes integer from pointer without a cast [-Wint-conversion]
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_HDATA);
^~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int' but argument is of type 'int *'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:230:25: warning: passing argument 3 of 'ntb_msg_read' makes pointer from integer without a cast [-Wint-conversion]
#define PERF_MSG_HDATA 2
^
drivers/ntb//test/ntb_perf.c:414:38: note: in expansion of macro 'PERF_MSG_HDATA'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_HDATA);
^~~~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int *' but argument is of type 'int'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:414:8: error: too few arguments to function 'ntb_msg_read'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_HDATA);
^~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: declared here
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c: In function 'perf_setup_peer_mw':
>> drivers/ntb//test/ntb_perf.c:1391:35: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
"Peer %d outbuf reduced to %#llx\n", peer->pidx,
~~~~^
%#x
peer->outbuf_size);
~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +1391 drivers/ntb//test/ntb_perf.c
1370
1371 static int perf_setup_peer_mw(struct perf_peer *peer)
1372 {
1373 struct perf_ctx *perf = peer->perf;
1374 phys_addr_t phys_addr;
1375 int ret;
1376
1377 /* Get outbound MW parameters and map it */
1378 ret = ntb_peer_mw_get_addr(perf->ntb, peer->gidx, &phys_addr,
1379 &peer->outbuf_size);
1380 if (ret)
1381 return ret;
1382
1383 peer->outbuf = devm_ioremap_wc(&perf->ntb->dev, phys_addr,
1384 peer->outbuf_size);
1385 if (!peer->outbuf)
1386 return -ENOMEM;
1387
1388 if (max_mw_size && peer->outbuf_size > max_mw_size) {
1389 peer->outbuf_size = max_mw_size;
1390 dev_warn(&peer->perf->ntb->dev,
> 1391 "Peer %d outbuf reduced to %#llx\n", peer->pidx,
1392 peer->outbuf_size);
1393 }
1394
1395 return 0;
1396 }
1397
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52291 bytes --]
prev parent reply other threads:[~2017-12-03 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 10:16 [PATCH] NTB: ntb_perf: Add full multi-port NTB API support Serge Semin
2017-11-30 21:38 ` [PATCH v2] " Serge Semin
2017-12-03 17:55 ` kbuild test robot
2017-12-03 17:58 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201712040133.bmgRyXdj%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=Allen.Hubbe@emc.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox