From: Jon Mason <jdmason@kudzu.us>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-ntb@googlegroups.com, allenbh@gmail.com, lucas.van@intel.com
Subject: Re: [PATCH] ntb: intel: fix return value for ndev_vec_mask()
Date: Wed, 31 Oct 2018 16:13:55 -0400 [thread overview]
Message-ID: <20181031201354.GA22474@kudzu.us> (raw)
In-Reply-To: <153550163921.39832.16483542818926290854.stgit@djiang5-desk3.ch.intel.com>
On Tue, Aug 28, 2018 at 05:13:59PM -0700, Dave Jiang wrote:
> ndev_vec_mask() should be returning u64 mask value instead of int.
> Otherwise the mask value returned can be incorrect for larger
> vectors.
>
> Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers")
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Tested-by: Lucas Van <lucas.van@intel.com>
Pulled into my ntb branch
Thanks,
Jon
> ---
> drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> index 6aa573227279..2ad263f708da 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c
> @@ -265,7 +265,7 @@ static inline int ndev_db_clear_mask(struct intel_ntb_dev *ndev, u64 db_bits,
> return 0;
> }
>
> -static inline int ndev_vec_mask(struct intel_ntb_dev *ndev, int db_vector)
> +static inline u64 ndev_vec_mask(struct intel_ntb_dev *ndev, int db_vector)
> {
> u64 shift, mask;
>
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/153550163921.39832.16483542818926290854.stgit%40djiang5-desk3.ch.intel.com.
> For more options, visit https://groups.google.com/d/optout.
prev parent reply other threads:[~2018-10-31 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 0:13 [PATCH] ntb: intel: fix return value for ndev_vec_mask() Dave Jiang
2018-10-31 20:13 ` Jon Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031201354.GA22474@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=linux-ntb@googlegroups.com \
--cc=lucas.van@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox