From: Jon Mason <jdmason@kudzu.us>
To: Sanjay R Mehta <sanmehta@amd.com>
Cc: Arindam Nath <arindam.nath@amd.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>, Jiasen Lin <linjiasen@hygon.cn>,
Sanjay R Mehta <sanju.mehta@amd.com>,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/15] AMD ntb driver fixes and improvements
Date: Thu, 12 Mar 2020 20:25:25 -0400 [thread overview]
Message-ID: <20200313002524.GB13046@kudzu.us> (raw)
In-Reply-To: <a8e98fe8-25da-3ea7-a204-2fee07c6061a@amd.com>
On Fri, Feb 07, 2020 at 04:28:53PM +0530, Sanjay R Mehta wrote:
>
>
> On 2/5/2020 9:24 PM, Arindam Nath wrote:
> > [CAUTION: External Email]
> >
> > This patch series fixes some bugs in the existing
> > AMD NTB driver, cleans-up code, and modifies the
> > code to handle NTB link-up/down events. The series
> > is based on Linus' tree,
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> >
> > Arindam Nath (15):
> > NTB: Fix access to link status and control register
> > NTB: clear interrupt status register
> > NTB: Enable link up and down event notification
> > NTB: define a new function to get link status
> > NTB: return the side info status from amd_poll_link
> > NTB: set peer_sta within event handler itself
> > NTB: remove handling of peer_sta from amd_link_is_up
> > NTB: handle link down event correctly
> > NTB: handle link up, D0 and D3 events correctly
> > NTB: move ntb_ctrl handling to init and deinit
> > NTB: add helper functions to set and clear sideinfo
> > NTB: return link up status correctly for PRI and SEC
> > NTB: remove redundant setting of DB valid mask
> > NTB: send DB event when driver is loaded or un-loaded
> > NTB: add pci shutdown handler for AMD NTB
>
> The patch series looks good to me. Thanks for the changes.
>
> For all the ntb_hw_amd changes:
>
> Reviewed-by: Sanjay R Mehta <sanju.mehta@amd.com>
I had to rework the first patch, since Jiasen's patch was already in
my tree for a couple months. The rest applied fine and will be in my
git trees on github in a couple of hours (sanity build pending).
Thanks,
Jon
>
>
> >
> > drivers/ntb/hw/amd/ntb_hw_amd.c | 290 ++++++++++++++++++++++++++------
> > drivers/ntb/hw/amd/ntb_hw_amd.h | 8 +-
> > 2 files changed, 247 insertions(+), 51 deletions(-)
> >
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2020-03-13 0:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 15:54 [PATCH 00/15] AMD ntb driver fixes and improvements Arindam Nath
2020-02-05 15:54 ` [PATCH 01/15] NTB: Fix access to link status and control register Arindam Nath
2020-02-05 15:54 ` [PATCH 02/15] NTB: clear interrupt status register Arindam Nath
2020-02-05 15:54 ` [PATCH 03/15] NTB: Enable link up and down event notification Arindam Nath
2020-02-05 15:54 ` [PATCH 04/15] NTB: define a new function to get link status Arindam Nath
2020-02-05 15:54 ` [PATCH 05/15] NTB: return the side info status from amd_poll_link Arindam Nath
2020-02-05 15:54 ` [PATCH 06/15] NTB: set peer_sta within event handler itself Arindam Nath
2020-02-05 15:54 ` [PATCH 07/15] NTB: remove handling of peer_sta from amd_link_is_up Arindam Nath
2020-02-05 15:54 ` [PATCH 08/15] NTB: handle link down event correctly Arindam Nath
2020-02-05 15:54 ` [PATCH 09/15] NTB: handle link up, D0 and D3 events correctly Arindam Nath
2020-02-05 15:54 ` [PATCH 10/15] NTB: move ntb_ctrl handling to init and deinit Arindam Nath
2020-02-05 15:54 ` [PATCH 11/15] NTB: add helper functions to set and clear sideinfo Arindam Nath
2020-02-05 15:54 ` [PATCH 12/15] NTB: return link up status correctly for PRI and SEC Arindam Nath
2020-02-05 15:54 ` [PATCH 13/15] NTB: remove redundant setting of DB valid mask Arindam Nath
2020-02-05 15:54 ` [PATCH 14/15] NTB: send DB event when driver is loaded or un-loaded Arindam Nath
2020-02-05 15:54 ` [PATCH 15/15] NTB: add pci shutdown handler for AMD NTB Arindam Nath
2020-02-07 10:58 ` [PATCH 00/15] AMD ntb driver fixes and improvements Sanjay R Mehta
2020-03-13 0:25 ` Jon Mason [this message]
2020-03-30 18:43 ` Nath, Arindam
2020-03-30 21:09 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313002524.GB13046@kudzu.us \
--to=jdmason@kudzu.us \
--cc=Shyam-sundar.S-k@amd.com \
--cc=allenbh@gmail.com \
--cc=arindam.nath@amd.com \
--cc=dave.jiang@intel.com \
--cc=linjiasen@hygon.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=sanju.mehta@amd.com \
--cc=sanmehta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox