From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F5DC2EE for ; Sat, 8 Apr 2023 09:33:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8BA8C433EF; Sat, 8 Apr 2023 09:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680946402; bh=1Na8BLaXtLhPBoLxzKdgkj/jz4zip9OEjD2Tn6ZX0ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zi1FXjTgjY4EAhLbkxFoXQGtfDYOBFigzjC/OeVE5bl2jDhvMUPHmbg0SJGrpbN9F 5gUfRL+LgiVJ21oIZAZLIdTvHS48G0OoQ9BmNvp6xwpZdqvnUcSK9RDeMTq1uWef4+ i9TvitAd/1XhsxeOPap19OZmIM2M+rLNv+t8NUR52KFKm3Rf1vbutb5Ai3cY+qxOEG PmisgCBtiuNe9U4p1FXSVdk/yZq+aW/Qx04r6cOkuWEpvKdvJRPubg+z/AWKMigw74 7iMOkuAtJNKt3NtteIs1A2QJ3xAF0QKLLQKXCVSfkOFwzc6PWH3ReN7rj+Hfm7e5hY HD6IcOwMklWlQ== Date: Sat, 8 Apr 2023 15:03:16 +0530 From: Manivannan Sadhasivam To: Jiasheng Jiang Cc: jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com, lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org, bhelgaas@google.com, ntb@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: endpoint: pci-epf-ntb: Add missing check for alloc_workqueue Message-ID: <20230408093316.GE11124@thinkpad> References: <20230104091601.22719-1-jiasheng@iscas.ac.cn> Precedence: bulk X-Mailing-List: ntb@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230104091601.22719-1-jiasheng@iscas.ac.cn> On Wed, Jan 04, 2023 at 05:16:01PM +0800, Jiasheng Jiang wrote: > Add check for the return value of alloc_workqueue since it may return > NULL pointer. > > Fixes: 8b821cf76150 ("PCI: endpoint: Add EP function driver to provide NTB functionality") > Signed-off-by: Jiasheng Jiang Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/endpoint/functions/pci-epf-ntb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-ntb.c b/drivers/pci/endpoint/functions/pci-epf-ntb.c > index 9a00448c7e61..304956bc0516 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-ntb.c > +++ b/drivers/pci/endpoint/functions/pci-epf-ntb.c > @@ -2124,6 +2124,9 @@ static int __init epf_ntb_init(void) > > kpcintb_workqueue = alloc_workqueue("kpcintb", WQ_MEM_RECLAIM | > WQ_HIGHPRI, 0); > + if (!kpcintb_workqueue) > + return -ENOMEM; > + > ret = pci_epf_register_driver(&epf_ntb_driver); > if (ret) { > destroy_workqueue(kpcintb_workqueue); > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்