Re: [PATCH 00/28] Remove PCI_IRQ_LEGACY

Bjorn Helgaas
2024-03-25T17:59:43Z

On Mon, Mar 25, 2024 at 04:09:11PM +0900, Damien Le Moal wrote:
> This patch series removes the use of the depracated PCI_IRQ_LEGACY macro
> and replace it with PCI_IRQ_INTX. No functional change.
>
> Damien Le Moal (28):
> PCI: msi: Use PCI_IRQ_INTX
> PCI: portdrv: Use PCI_IRQ_INTX
> PCI: documentation: Use PCI_IRQ_INTX
> sound: intel: Use PCI_IRQ_INTX
> usb: hcd-pci: Use PCI_IRQ_INTX
> tty: 8250_pci: Use PCI_IRQ_INTX
> platform: intel_ips: Use PCI_IRQ_INTX
> ntb: Use PCI_IRQ_INTX
> mfd: intel-lpss-pci: Use PCI_IRQ_INTX
> drm: amdgpu: Use PCI_IRQ_INTX
> infiniband: qib: Use PCI_IRQ_INTX
> infiniband: vmw_pvrdma: Use PCI_IRQ_INTX
> misc: vmci_guest: Use PCI_IRQ_ALL_TYPES
> net: xgbe: Use PCI_IRQ_INTX
> net: aquantia atlantic: Use PCI_IRQ_INTX
> net: atheros: alx: Use PCI_IRQ_INTX
> net: realtek: r8169: Use PCI_IRQ_INTX
> net: wangxun: Use PCI_IRQ_INTX
> net: wireless: ath10k: Use references to INTX instead of LEGACY
> net wireless; realtec: Use PCI_IRQ_INTX
> scsi: arcmsr: Use PCI_IRQ_INTX
> scsi: hpsa: Use PCI_IRQ_INTX
> scsi: ipr: Use PCI_IRQ_INTX
> scsi: megaraid: Use PCI_IRQ_INTX
> scsi: mpt3sas: Use PCI_IRQ_INTX
> scsi: pmcraid: Use PCI_IRQ_INTX
> scsi: vmw_pvscsi: Do not use PCI_IRQ_LEGACY
> PCI: Remove PCI_IRQ_LEGACY
>
> Documentation/PCI/msi-howto.rst | 2 +-
> Documentation/PCI/pci.rst | 2 +-
> .../translations/zh_CN/PCI/msi-howto.rst | 2 +-
> Documentation/translations/zh_CN/PCI/pci.rst | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +-
> drivers/infiniband/hw/qib/qib_iba7220.c | 2 +-
> drivers/infiniband/hw/qib/qib_iba7322.c | 5 ++-
> drivers/infiniband/hw/qib/qib_pcie.c | 2 +-
> .../infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
> drivers/mfd/intel-lpss-pci.c | 2 +-
> drivers/misc/vmw_vmci/vmci_guest.c | 3 +-
> drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 2 +-
> .../net/ethernet/aquantia/atlantic/aq_cfg.h | 2 +-
> .../net/ethernet/aquantia/atlantic/aq_hw.h | 2 +-
> .../net/ethernet/aquantia/atlantic/aq_nic.c | 2 +-
> .../ethernet/aquantia/atlantic/aq_pci_func.c | 9 ++---
> .../aquantia/atlantic/hw_atl/hw_atl_a0.c | 2 +-
> .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +-
> .../aquantia/atlantic/hw_atl2/hw_atl2.c | 2 +-
> drivers/net/ethernet/atheros/alx/main.c | 2 +-
> drivers/net/ethernet/realtek/r8169_main.c | 2 +-
> drivers/net/ethernet/wangxun/libwx/wx_lib.c | 8 ++---
> drivers/net/wireless/ath/ath10k/ahb.c | 18 +++++-----
> drivers/net/wireless/ath/ath10k/pci.c | 36 +++++++++----------
> drivers/net/wireless/ath/ath10k/pci.h | 6 ++--
> drivers/net/wireless/realtek/rtw88/pci.c | 2 +-
> drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
> drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +-
> drivers/pci/msi/api.c | 8 ++---
> drivers/pci/pcie/portdrv.c | 8 ++---
> drivers/platform/x86/intel_ips.c | 2 +-
> drivers/scsi/arcmsr/arcmsr_hba.c | 2 +-
> drivers/scsi/hpsa.c | 2 +-
> drivers/scsi/ipr.c | 2 +-
> drivers/scsi/megaraid/megaraid_sas_base.c | 4 +--
> drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
> drivers/scsi/pmcraid.c | 2 +-
> drivers/scsi/vmw_pvscsi.c | 2 +-
> drivers/tty/serial/8250/8250_pci.c | 2 +-
> drivers/usb/core/hcd-pci.c | 3 +-
> include/linux/pci.h | 7 ++--
> sound/soc/intel/avs/core.c | 2 +-
> 42 files changed, 84 insertions(+), 91 deletions(-)

I applied all these to pci/enumeration for v6.10, thanks!

I added acks and reviewed-by and will update if we receive more, and
adjusted subject lines to add "... instead of PCI_IRQ_LEGACY" and in
some cases to match history of the file.

Bjorn