* [PATCH -next v2] ntb: Fix kernel-doc param for ntb_transport_create_queue
@ 2024-06-07 7:57 Yang Li
2024-06-07 16:14 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2024-06-07 7:57 UTC (permalink / raw)
To: dave.jiang, jdmason, allenbh; +Cc: ntb, linux-kernel, Yang Li
The patch updates ntb_transport_create_queue() kdoc header to specify the
correct input parameters used by the function.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/ntb/ntb_transport.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index f9e7847a378e..5d466a3f117b 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -1966,9 +1966,10 @@ static bool ntb_dma_filter_fn(struct dma_chan *chan, void *node)
/**
* ntb_transport_create_queue - Create a new NTB transport layer queue
- * @rx_handler: receive callback function
- * @tx_handler: transmit callback function
- * @event_handler: event callback function
+ * @data: user-defined data to associate with the queue
+ * @client_dev: the device structure of the NTB client
+ * @handlers: structure containing receive, transmit, and event callback
+ * functions
*
* Create a new NTB transport layer queue and provide the queue with a callback
* routine for both transmit and receive. The receive callback routine will be
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] ntb: Fix kernel-doc param for ntb_transport_create_queue
2024-06-07 7:57 [PATCH -next v2] ntb: Fix kernel-doc param for ntb_transport_create_queue Yang Li
@ 2024-06-07 16:14 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2024-06-07 16:14 UTC (permalink / raw)
To: Yang Li, jdmason, allenbh; +Cc: ntb, linux-kernel
On 6/7/24 12:57 AM, Yang Li wrote:
> The patch updates ntb_transport_create_queue() kdoc header to specify the
> correct input parameters used by the function.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thank you!
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
I do recommend attaching the revision history below the '---' line next time for common patch posting practice. Thanks
> drivers/ntb/ntb_transport.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index f9e7847a378e..5d466a3f117b 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -1966,9 +1966,10 @@ static bool ntb_dma_filter_fn(struct dma_chan *chan, void *node)
>
> /**
> * ntb_transport_create_queue - Create a new NTB transport layer queue
> - * @rx_handler: receive callback function
> - * @tx_handler: transmit callback function
> - * @event_handler: event callback function
> + * @data: user-defined data to associate with the queue
> + * @client_dev: the device structure of the NTB client
> + * @handlers: structure containing receive, transmit, and event callback
> + * functions
> *
> * Create a new NTB transport layer queue and provide the queue with a callback
> * routine for both transmit and receive. The receive callback routine will be
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-07 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-07 7:57 [PATCH -next v2] ntb: Fix kernel-doc param for ntb_transport_create_queue Yang Li
2024-06-07 16:14 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox