From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A04C1F5BF4; Fri, 4 Oct 2024 18:22:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066178; cv=none; b=nnQi1UKxMYKbv/e4IWGShXChXHqHQADfN5jWFN2MNynDJsXIUH/ZDuiFIBQpLVuJJdtbDhNl2c30ujH2Ks/yhSJZRgnOAUrJxth0kOHllmTm+YBur1LN+VR57fFtWpGAZ62WAmjs+3VXN4Xuqsn2aeAQfMkTb0causd+6deN96o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728066178; c=relaxed/simple; bh=7biog2O1wtlDY/U3f/tEE7P320v8j07FtsbL4Do3tIg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C3IlP61Nwm6R5KuQtuCdYIyzL6z3w7xpCih9d6mVo2Epzi8YIJ30dKQYuO78cFYvsYsMtTvPfg+An2VzNLU6P02e4WNvEm9SI25UGDRiE3n1M7TwEvEdiIvpmx8GJ4DbIDWXZzzey0qrRN8eXRYXxTN7BaJwi/fS7P/m/n99SWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r7cJlccX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r7cJlccX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD8D0C4CECE; Fri, 4 Oct 2024 18:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728066178; bh=7biog2O1wtlDY/U3f/tEE7P320v8j07FtsbL4Do3tIg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r7cJlccXkRMExy+Vd3yIaKIgmjuJ8h3w3pa3clFFF+ye5gpmJjvGz4mJUZRXYrhXe E+xSxdM6mYSLnEwulrdw5ThZKHkmGrcco53TYO6Dl0naoAc16e9fQOGPMaXCUrkKPS P84zup5iD1zMEfeorVeWss89r0+VFBJes3/t5JFKfGcBODavI8Ha21ln0O6xSc0Hb5 qDLo0CaH0akTQ7n6oE0PIGF38n9GGBvKlCr+MPydm/SRj/t7J6Odo5HI9YAhNZm0ru itI/ts5isVMQmOb0LKf2WSjr0oj17Wj8ri6cCEVTJUCVinK8fku1rJ1UN/B8nU4t64 eeyapEAOzV9qw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kaixin Wang , Logan Gunthorpe , Jon Mason , Sasha Levin , kurt.schwemmer@microsemi.com, dave.jiang@intel.com, allenbh@gmail.com, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH AUTOSEL 6.10 32/70] ntb: ntb_hw_switchtec: Fix use after free vulnerability in switchtec_ntb_remove due to race condition Date: Fri, 4 Oct 2024 14:20:30 -0400 Message-ID: <20241004182200.3670903-32-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241004182200.3670903-1-sashal@kernel.org> References: <20241004182200.3670903-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: ntb@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.13 Content-Transfer-Encoding: 8bit From: Kaixin Wang [ Upstream commit e51aded92d42784313ba16c12f4f88cc4f973bbb ] In the switchtec_ntb_add function, it can call switchtec_ntb_init_sndev function, then &sndev->check_link_status_work is bound with check_link_status_work. switchtec_ntb_link_notification may be called to start the work. If we remove the module which will call switchtec_ntb_remove to make cleanup, it will free sndev through kfree(sndev), while the work mentioned above will be used. The sequence of operations that may lead to a UAF bug is as follows: CPU0 CPU1 | check_link_status_work switchtec_ntb_remove | kfree(sndev); | | if (sndev->link_force_down) | // use sndev Fix it by ensuring that the work is canceled before proceeding with the cleanup in switchtec_ntb_remove. Signed-off-by: Kaixin Wang Reviewed-by: Logan Gunthorpe Signed-off-by: Jon Mason Signed-off-by: Sasha Levin --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c index d6bbcc7b5b90d..0a94c634ddc27 100644 --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c @@ -1554,6 +1554,7 @@ static void switchtec_ntb_remove(struct device *dev) switchtec_ntb_deinit_db_msg_irq(sndev); switchtec_ntb_deinit_shared_mw(sndev); switchtec_ntb_deinit_crosslink(sndev); + cancel_work_sync(&sndev->check_link_status_work); kfree(sndev); dev_info(dev, "ntb device unregistered\n"); } -- 2.43.0