* CVE-2023-52917: ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
@ 2025-03-02 17:18 Ben Hutchings
2025-03-03 8:11 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2025-03-02 17:18 UTC (permalink / raw)
To: Dave Jiang, Jinjie Ruan, cve; +Cc: ntb
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hi all,
CVE-2023-52917 is supposed to be fixed by commit e229897d373a "ntb:
intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()", but I
think this assignment should be rejected.
While it's usually a bug to use an error-pointer as a function argument,
and such bugs may be exploitable for denial-of-service, the debugfs file
creation functions are specifically intended to accept an error-pointer
as a parent pointer and they do nothing in that case. Therefore there
was no security flaw to be fixed.
Ben.
--
Ben Hutchings
Any smoothly functioning technology is indistinguishable
from a rigged demo.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: CVE-2023-52917: ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
2025-03-02 17:18 CVE-2023-52917: ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir() Ben Hutchings
@ 2025-03-03 8:11 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-03-03 8:11 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Dave Jiang, Jinjie Ruan, cve, ntb
On Sun, Mar 02, 2025 at 06:18:21PM +0100, Ben Hutchings wrote:
> Hi all,
>
> CVE-2023-52917 is supposed to be fixed by commit e229897d373a "ntb:
> intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()", but I
> think this assignment should be rejected.
>
> While it's usually a bug to use an error-pointer as a function argument,
> and such bugs may be exploitable for denial-of-service, the debugfs file
> creation functions are specifically intended to accept an error-pointer
> as a parent pointer and they do nothing in that case. Therefore there
> was no security flaw to be fixed.
Now rejected, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-03 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-02 17:18 CVE-2023-52917: ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir() Ben Hutchings
2025-03-03 8:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox