Re: CVE-2023-52917: ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

Greg KH
2025-03-03T08:12:25Z

On Sun, Mar 02, 2025 at 06:18:21PM +0100, Ben Hutchings wrote:
> Hi all,
>
> CVE-2023-52917 is supposed to be fixed by commit e229897d373a "ntb:
> intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()", but I
> think this assignment should be rejected.
>
> While it's usually a bug to use an error-pointer as a function argument,
> and such bugs may be exploitable for denial-of-service, the debugfs file
> creation functions are specifically intended to accept an error-pointer
> as a parent pointer and they do nothing in that case. Therefore there
> was no security flaw to be fixed.

Now rejected, thanks.

greg k-h