CVE-2023-52917: ntb: intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

Ben Hutchings
2025-03-02T17:18:54Z

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hi all,

CVE-2023-52917 is supposed to be fixed by commit e229897d373a "ntb:
intel: Fix the NULL vs IS_ERR() bug for debugfs_create_dir()", but I
think this assignment should be rejected.

While it's usually a bug to use an error-pointer as a function argument,
and such bugs may be exploitable for denial-of-service, the debugfs file
creation functions are specifically intended to accept an error-pointer
as a parent pointer and they do nothing in that case. Therefore there
was no security flaw to be fixed.

Ben.

--
Ben Hutchings
Any smoothly functioning technology is indistinguishable
from a rigged demo.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]