From: Koichiro Den <den@valinux.co.jp>
To: ntb@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com
Subject: [PATCH 1/2] NTB: ntb_transport: Remove unused 'retries' field from ntb_queue_entry
Date: Thu, 23 Oct 2025 16:21:04 +0900 [thread overview]
Message-ID: <20251023072105.901707-2-den@valinux.co.jp> (raw)
In-Reply-To: <20251023072105.901707-1-den@valinux.co.jp>
Drop the unused field 'retries' from struct ntb_queue_entry for
simplicity's sake.
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
drivers/ntb/ntb_transport.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
index eb875e3db2e3..39b2398b95a6 100644
--- a/drivers/ntb/ntb_transport.c
+++ b/drivers/ntb/ntb_transport.c
@@ -113,7 +113,6 @@ struct ntb_queue_entry {
void *buf;
unsigned int len;
unsigned int flags;
- int retries;
int errors;
unsigned int tx_index;
unsigned int rx_index;
@@ -1630,9 +1629,7 @@ static void ntb_async_rx(struct ntb_queue_entry *entry, void *offset)
if (res < 0)
goto err;
- if (!entry->retries)
- qp->rx_async++;
-
+ qp->rx_async++;
return;
err:
@@ -1910,9 +1907,7 @@ static void ntb_async_tx(struct ntb_transport_qp *qp,
if (res < 0)
goto err;
- if (!entry->retries)
- qp->tx_async++;
-
+ qp->tx_async++;
return;
err:
@@ -2273,7 +2268,6 @@ int ntb_transport_rx_enqueue(struct ntb_transport_qp *qp, void *cb, void *data,
entry->buf = data;
entry->len = len;
entry->flags = 0;
- entry->retries = 0;
entry->errors = 0;
entry->rx_index = 0;
@@ -2323,7 +2317,6 @@ int ntb_transport_tx_enqueue(struct ntb_transport_qp *qp, void *cb, void *data,
entry->len = len;
entry->flags = 0;
entry->errors = 0;
- entry->retries = 0;
entry->tx_index = 0;
rc = ntb_process_tx(qp, entry);
--
2.48.1
next prev parent reply other threads:[~2025-10-23 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 7:21 [PATCH 0/2] Add 'tx_memcpy_offload' option to ntb_transport Koichiro Den
2025-10-23 7:21 ` Koichiro Den [this message]
2025-10-23 14:59 ` [PATCH 1/2] NTB: ntb_transport: Remove unused 'retries' field from ntb_queue_entry Dave Jiang
2025-10-23 7:21 ` [PATCH 2/2] NTB: ntb_transport: Add 'tx_memcpy_offload' module option Koichiro Den
2025-10-23 15:18 ` Dave Jiang
2025-10-24 16:41 ` Koichiro Den
2025-10-24 17:05 ` Dave Jiang
2025-10-27 3:20 ` Koichiro Den
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023072105.901707-2-den@valinux.co.jp \
--to=den@valinux.co.jp \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox