Re: [PATCH v2 1/4] NTB : Introduce message library

[Atul Raut <araut@codeaurora.org>]

Hi Logan,

Thanks for reviewing patches.

>> Should we really encode the type of data sent in the library?
Agree, few points would like to bring it here & see if that makes
sense ?
1. Here Library brings some useful things, that  currently two 
client are using it with assumption that these things may
need for feature clients as well.
2. The main objective of library is to solve common problem
that any client driver may have, and that is configuring
inbound/outbound memory window by sharing some info using these
registers in certain way, one way is my patch that derived from
Sergey's ntb_perf module.
The idea is to have basic infrastructure in place which solves
basic configuration problem for any client driver.
Not sure these answers your question, but if any one has some
other suggestions on library implementation I will give an try.

>> Do we really need a cmd_wid message? 
These will act dummy for scratchpad based registers, added just to 
have common API's for scratchpad & message registers.
 
Regards,
Atul

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project