From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1488D2147E5 for ; Wed, 9 Apr 2025 11:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744199351; cv=none; b=jzbRhmwYM6EflGz4E25cgx11E9Zg1DBANPJs8/G3OlmWhOth+v1n8FkGeeIbJtsU0nHAe3gyZSXK0ZJhuwjgxGGWkrZ31sqlAlRkVAon8vzldaDdLj8AWZKrmGrsvC068njMKI/AFApFISV6W/z/s8kUUoh36v1FajevQKcRLcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744199351; c=relaxed/simple; bh=b89AxCC0or7u4BnPQBzKZbFr3LbSbaCir0htR+5n8Bg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d4cvxMGpHIOpi14CY9cyatwdaaQebJ78CHX3pNK6fiXd9LmBpZquskXYmyoHnUwdbB0L6jvPQHpZqIv8+Pih+SkIplBcG0UPoBGxQJe4WeWXbcgIC76TedT1M80+MAkxVWaOcolMRBaD6Ffd/PHdojcJSxv7Ukwmic0WwEunnSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Wuv6sRTX; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Wuv6sRTX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744199351; x=1775735351; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=b89AxCC0or7u4BnPQBzKZbFr3LbSbaCir0htR+5n8Bg=; b=Wuv6sRTXKRP3Lz8RWlnprEyG6E3BF3nS9x2OMHXDde0DOmDDifGxRR+7 qmMMjL7+/wciig1XLzSK0DqkKcnXwxTnTxZU41W+Ua1B/R91kXHqyUxf7 cc9l9Ls9F11qTjEqDD3ClQa7zKbltMxsMeegXnumz0saT9wDfWNgNL+LL depsR2yd8TdmIpABggz8Ew/lHiS7LVKiYqW3ozIJaHeV2I0+xP1YyJss5 FAwj0RDSy07LvwJWkoQvqhd2867z922kzE2VXvzP0G5Tqlu7Nq3npeU0M /nuQVcBB46Rox1O1L7MXqSx5rXwPSXdw8vQBR1cYQcu+xx1fhazWOUP64 Q==; X-CSE-ConnectionGUID: ghilhAEkRg+FORQjsVyxqw== X-CSE-MsgGUID: pyik+JuVTkOZN2Fcvp0gBw== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="63067299" X-IronPort-AV: E=Sophos;i="6.15,200,1739865600"; d="scan'208";a="63067299" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 04:49:10 -0700 X-CSE-ConnectionGUID: u2zyH/jVQKaveoc+s3fo7g== X-CSE-MsgGUID: cOSZSGWeTsa7lCiW7CGzpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,200,1739865600"; d="scan'208";a="165780107" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa001.jf.intel.com with ESMTP; 09 Apr 2025 04:49:04 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3BF64541; Wed, 09 Apr 2025 14:49:02 +0300 (EEST) Date: Wed, 9 Apr 2025 14:49:01 +0300 From: Andy Shevchenko To: Thomas Gleixner Cc: Bert Karwatzki , Bjorn Helgaas , linux-kernel@vger.kernel.org, James.Bottomley@hansenpartnership.com, Jonathan.Cameron@huawei.com, allenbh@gmail.com, d-gole@ti.com, dave.jiang@intel.com, haiyangz@microsoft.com, jdmason@kudzu.us, kristo@kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, logang@deltatee.com, manivannan.sadhasivam@linaro.org, martin.petersen@oracle.com, maz@kernel.org, mhklinux@outlook.com, nm@ti.com, ntb@lists.linux.dev, peterz@infradead.org, ssantosh@kernel.org, wei.huang2@amd.com, wei.liu@kernel.org Subject: Re: commit 7b025f3f85ed causes NULL pointer dereference Message-ID: References: <20250408120446.3128-1-spasswolf@web.de> <87iknevgfb.ffs@tglx> <87friivfht.ffs@tglx> <87a58qv0tn.ffs@tglx> Precedence: bulk X-Mailing-List: ntb@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a58qv0tn.ffs@tglx> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Apr 08, 2025 at 10:46:12PM +0200, Thomas Gleixner wrote: > On Tue, Apr 08 2025 at 18:20, Bert Karwatzki wrote: > > Am Dienstag, dem 08.04.2025 um 17:29 +0200 schrieb Thomas Gleixner: > >> > Can you please decode the lines please via: > >> > > >> > scripts/faddr2line vmlinux msi_domain_first_desc+0x4/0x30 > >> > scripts/faddr2line vmlinux msix_setup_interrupts+0x23b/0x280 Also hit this, bisected to this change and in my case it's Clang 19. > > I had to recompile with CONFIG_DEBUG_INFO=Y, and reran the test, the calltrace > > is identical. > > > > $ scripts/faddr2line vmlinux msi_domain_first_desc+0x4/0x30 > > msi_domain_first_desc+0x4/0x30: > > msi_domain_first_desc at kernel/irq/msi.c:400 > > > > So it seems msi_domain_first_desc() is called with dev = NULL. > > Yup > > > $ scripts/faddr2line vmlinux msix_setup_interrupts+0x23b/0x280 > > msix_setup_interrupts+0x23b/0x280: > > msix_update_entries at drivers/pci/msi/msi.c:647 (discriminator 1) > > Aaarg. The patch below should fix that. Tested-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko