Re: [PATCH v5 2/4] PCI: endpoint: Add helper function pci_epf_get_bar_required_size()

Niklas Cassel
2025-10-13T09:04:48Z

On Thu, Oct 09, 2025 at 04:54:36PM -0400, Frank Li wrote:
> Introduce pci_epf_get_bar_required_size() to retrieve the required BAR
> size and memory size. Prepare for adding support to set an MMIO address to
> a specific BAR.
>
> Use two variables 'size' and 'aligned_mem_size' to avoid confuse.

Nit: I still think this is wrong. Probably:
Use two parameters 'bar_size' and 'aligned_mem_size' to avoid confusion.

>
> No functional changes.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Reviewed-by: Niklas Cassel <cassel@kernel.org>