public inbox for ntb@lists.linux.dev
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>,
	ntb@lists.linux.dev
Subject: Re: [PATCH] NTB: fix kernel-doc warnings in ntb.h
Date: Thu, 12 Mar 2026 10:11:59 -0700	[thread overview]
Message-ID: <e900da77-b277-4f40-9c6c-316805ca0b01@intel.com> (raw)
In-Reply-To: <20260312051415.683874-1-rdunlap@infradead.org>



On 3/11/26 10:14 PM, Randy Dunlap wrote:
> Correct a function name and function parameter name to avoid
> kernel-doc warnings:
> 
> Warning: include/linux/ntb.h:575 expecting prototype for
>  ntb_default_port_count(). Prototype was for ntb_default_peer_port_count()
>  instead
> Warning: include/linux/ntb.h:590 function parameter 'pidx' not
>  described in 'ntb_default_peer_port_number'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Jon Mason <jdmason@kudzu.us>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Allen Hubbe <allenbh@gmail.com>
> Cc: ntb@lists.linux.dev

Acked-by: Dave Jiang <dave.jiang@intel.com>

> 
>  include/linux/ntb.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20260311.orig/include/linux/ntb.h
> +++ linux-next-20260311/include/linux/ntb.h
> @@ -563,7 +563,7 @@ void ntb_msg_event(struct ntb_dev *ntb);
>  int ntb_default_port_number(struct ntb_dev *ntb);
>  
>  /**
> - * ntb_default_port_count() - get the default number of peer device ports
> + * ntb_default_peer_port_count() - get the default number of peer device ports
>   * @ntb:	NTB device context.
>   *
>   * By default hardware driver supports just one peer device.
> @@ -578,7 +578,7 @@ int ntb_default_peer_port_count(struct n
>  /**
>   * ntb_default_peer_port_number() - get the default peer port by given index
>   * @ntb:	NTB device context.
> - * @idx:	Peer port index (should not differ from zero).
> + * @pidx:	Peer port index (should not differ from zero).
>   *
>   * By default hardware driver supports just one peer device, so this method
>   * shall return the corresponding value from enum ntb_default_port.


      reply	other threads:[~2026-03-12 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12  5:14 [PATCH] NTB: fix kernel-doc warnings in ntb.h Randy Dunlap
2026-03-12 17:11 ` Dave Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e900da77-b277-4f40-9c6c-316805ca0b01@intel.com \
    --to=dave.jiang@intel.com \
    --cc=allenbh@gmail.com \
    --cc=jdmason@kudzu.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntb@lists.linux.dev \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox