From: Dave Jiang <dave.jiang@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>, ntb@lists.linux.dev
Cc: Jon Mason <jdmason@kudzu.us>, Allen Hubbe <allenbh@gmail.com>
Subject: Re: [PATCH] ntb: Use %p for pointer formatting
Date: Fri, 18 Sep 2026 07:40:01 -0700 [thread overview]
Message-ID: <e9bf9ac4-9b13-4ae8-ae9c-949b33d63da5@intel.com> (raw)
In-Reply-To: <20260918103914.XRVeXpwB@linutronix.de>
On 9/18/26 3:39 AM, Sebastian Andrzej Siewior wrote:
> Since commit ad67b74d2469d ("printk: hash addresses printed with
> %p") pointers are hashed by default and the behaviour can be controller
> by `hash_pointers' boot argument.
> The policy on %p is to not introduce new ones.
> Removing %pK makes it possible to remove its handling from the library.
>
> The usage here is restricted to debugfs and testing.
>
> Use %p instead %pK.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/ntb/test/ntb_perf.c | 4 ++--
> drivers/ntb/test/ntb_tool.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index dfd175f79e8f0..c4c572c754f18 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1222,7 +1222,7 @@ static ssize_t perf_dbgfs_read_info(struct file *filep, char __user *ubuf,
> test_bit(PERF_STS_LNKUP, &peer->sts) ? "up" : "down");
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buffer addr 0x%pK\n", peer->outbuf);
> + "\tOut buffer addr 0x%p\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
> @@ -1240,7 +1240,7 @@ static ssize_t perf_dbgfs_read_info(struct file *filep, char __user *ubuf,
> }
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tIn buffer addr 0x%pK\n", peer->inbuf);
> + "\tIn buffer addr 0x%p\n", peer->inbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tIn buffer size %pa\n", &peer->inbuf_size);
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 06881047f5bcd..63d830924ae91 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -666,7 +666,7 @@ static ssize_t tool_mw_trans_read(struct file *filep, char __user *ubuf,
> inmw->pidx);
>
> off += scnprintf(buf + off, buf_size - off,
> - "Window Address \t0x%pK\n", inmw->mm_base);
> + "Window Address \t0x%p\n", inmw->mm_base);
>
> off += scnprintf(buf + off, buf_size - off,
> "DMA Address \t%pad\n",
> @@ -899,7 +899,7 @@ static ssize_t tool_peer_mw_trans_read(struct file *filep, char __user *ubuf,
> }
>
> off += scnprintf(buf + off, buf_size - off,
> - "Virtual address \t0x%pK\n", outmw->io_base);
> + "Virtual address \t0x%p\n", outmw->io_base);
>
> off += scnprintf(buf + off, buf_size - off,
> "Phys Address \t%pap\n", &map_base);
prev parent reply other threads:[~2026-09-18 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 10:39 [PATCH] ntb: Use %p for pointer formatting Sebastian Andrzej Siewior
2026-09-18 14:40 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9bf9ac4-9b13-4ae8-ae9c-949b33d63da5@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=jdmason@kudzu.us \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox