From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com. [207.54.116.67]) by gmr-mx.google.com with ESMTPS id t131si161633ita.1.2017.07.20.08.39.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jul 2017 08:39:51 -0700 (PDT) References: <20170718165528.7383-1-logang@deltatee.com> <20170718165528.7383-2-logang@deltatee.com> <87iniphsug.fsf@concordia.ellerman.id.au> <15b6ea7d-5817-c0cd-aee4-c8a52d8808f9@deltatee.com> From: Logan Gunthorpe Message-ID: Date: Thu, 20 Jul 2017 09:39:33 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs To: =?UTF-8?Q?Horia_Geant=c4=83?= , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-ntb@googlegroups.com" , "linux-crypto@vger.kernel.org" Cc: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Benjamin Herrenschmidt , Paul Mackerras , Nicholas Piggin , Suresh Warrier , Oliver O'Halloran List-ID: On 20/07/17 06:36 AM, Horia Geant=EF=BF=BD wrote: > include/asm-generic/iomap.h is included before > include/linux/io-64-nonatomic-lo-hi.h: >=20 > include/linux/io.h -> arch/powerpc/include/asm/io.h -> > include/asm-generic/iomap.h >=20 > Thus, the "extern" version of ioread64_lo_hi and friends will be used > (and not the inline version from io-64-nonatomic-lo-hi.h). >=20 > But for this kernel .config: > -CONFIG_GENERIC_IOMAP=3Dn and > -there is no implementation of io{read|write}64[be]{_lo_hi|_hi_lo} in > arch/powerpc/kernel/iomap.c Ah, thanks for the triage. I'll take a look at fixing this for a v5. Logan