From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Yang Yingliang <yangyingliang@huaweicloud.com>
Cc: ntb@lists.linux.dev, linux-pci@vger.kernel.org, jdmason@kudzu.us,
dave.jiang@intel.com, allenbh@gmail.com, lpieralisi@kernel.org,
kw@linux.com, mani@kernel.org, kishon@kernel.org,
bhelgaas@google.com, yangyingliang@huawei.com
Subject: Re: [PATCH 1/2] NTB: fix possible name leak in ntb_register_device()
Date: Tue, 5 Dec 2023 11:59:21 +0200 (EET) [thread overview]
Message-ID: <ffce9b96-09d-657-37c6-8181d929221@linux.intel.com> (raw)
In-Reply-To: <20231201033057.1399131-1-yangyingliang@huaweicloud.com>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Fri, 1 Dec 2023, Yang Yingliang wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
>
> If device_register() returns error in ntb_register_device(),
> the name allocated by dev_set_name() need be freed. As comment
> of device_register() says, it should use put_device() to give
> up the reference in the error path. So fix this by calling
> put_device(), then the name can be freed in kobject_cleanup().
>
> Remove the outside put_device() in pci_vntb_probe() and return
> the error code.
>
> Fixes: a1bd3baeb2f1 ("NTB: Add NTB hardware abstraction layer")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-12-05 9:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 3:30 [PATCH 1/2] NTB: fix possible name leak in ntb_register_device() Yang Yingliang
2023-12-01 3:30 ` [PATCH 2/2] NTB: EPF: return error code in the error path in pci_vntb_probe() Yang Yingliang
2023-12-01 5:48 ` Manivannan Sadhasivam
2023-12-01 17:41 ` Dave Jiang
2023-12-05 9:59 ` Ilpo Järvinen
2023-12-01 5:48 ` [PATCH 1/2] NTB: fix possible name leak in ntb_register_device() Manivannan Sadhasivam
2023-12-01 17:41 ` Dave Jiang
2023-12-05 9:59 ` Ilpo Järvinen [this message]
2024-02-16 10:45 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffce9b96-09d-657-37c6-8181d929221@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=ntb@lists.linux.dev \
--cc=yangyingliang@huawei.com \
--cc=yangyingliang@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox