Re: [PATCH v7 05/13] fat: make fat_update_time get its own timestamp

OGAWA Hirofumi
2023-08-09T20:14:37Z

Jeff Layton <jlayton@kernel.org> writes:

> When you say it "doesn't work the same", what do you mean, specifically?
> I had to make some allowances for the fact that FAT is substantially
> different in its timestamp handling, and I tried to preserve existing
> behavior as best I could.

Ah, ok. I was misreading some.

inode_update_timestamps() checks IS_I_VERSION() now, not S_VERSION. So,
if adding the check of IS_I_VERSION() and (S_MTIME|S_CTIME|S_VERSION) to
FAT?

With it, IS_I_VERSION() would be false on FAT, and I'm fine.

I.e. something like

if ((flags & (S_VERSION|S_CTIME|S_MTIME)) && IS_I_VERSION(inode)
&& inode_maybe_inc_iversion(inode, false))
dirty_flags |= I_DIRTY_SYNC;

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>