Re: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting

Pali Rohár
2021-08-19T08:18:31Z

Hello! I have there one comment:

On Thursday 19 August 2021 03:26:30 Kari Argillander wrote:
> @@ -545,10 +518,8 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
> seq_printf(m, ",fmask=%04o", ~opts->fs_fmask_inv);
> if (opts->dmask)
> seq_printf(m, ",dmask=%04o", ~opts->fs_dmask_inv);
> - if (opts->nls)
> - seq_printf(m, ",nls=%s", opts->nls->charset);
> - else
> - seq_puts(m, ",nls=utf8");
> + if (opts->nls_name)
> + seq_printf(m, ",nls=%s", opts->nls_name);

Please always print correct "nls=". Obviously ntfs driver (which
internally stores filenames in UTF-16) must always use some conversion
to null-term bytes. And if some kernel/driver default conversion is used
then userspace should know it, what exactly is used (e.g. to ensure that
would use correct encoding name argument of open(), stat()... syscalls).

> if (opts->sys_immutable)
> seq_puts(m, ",sys_immutable");
> if (opts->discard)
> @@ -619,7 +590,6 @@ static const struct super_operations ntfs_sops = {
> .statfs = ntfs_statfs,
> .show_options = ntfs_show_options,
> .sync_fs = ntfs_sync_fs,
> - .remount_fs = ntfs_remount,
> .write_inode = ntfs3_write_inode,
> };