Re: [PATCH v2 3/6] fs/ntfs3: Use new api for mounting

Christoph Hellwig
2021-08-24T08:03:05Z

> + /*
> + * TODO: We should probably check some mount options does
> + * they all work after remount. Example can we really change
> + * nls. Remove this comment when all testing is done or
> + * even better xfstest is made for it.
> + */

Instead of the TODO I would suggest a prep patch to drop changing of
any options in remount before this one and then only add them back
as needed and tested.

The mechanics of the conversion look good to me.