From: Kari Argillander <kari.argillander@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/ntfs3: Remove unnecessary condition checking from ntfs_file_read_iter
Date: Wed, 25 Aug 2021 22:31:00 +0300 [thread overview]
Message-ID: <20210825193100.fix4o2p7swifru5o@kari-VirtualBox> (raw)
In-Reply-To: <20210825191757.GW7722@kadam>
On Wed, Aug 25, 2021 at 10:17:57PM +0300, Dan Carpenter wrote:
> On Wed, Aug 25, 2021 at 09:25:22PM +0300, Kari Argillander wrote:
> > This check will be also performed in generic_file_read_iter() so we do
> > not want to check this two times in a row.
> >
> > This was founded with Smatch
> > fs/ntfs3/file.c:803 ntfs_file_read_iter()
> > warn: unused return: count = iov_iter_count()
> >
> > Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
> > ---
> > I cc Dan also because I am happy that I finally managed to install
> > Smack and straight away I found something with it. Thank you for
> > this great tool.
>
> Thanks!
>
> You got a bit lucky, because you're using the --two-passes and the truth
> is I haven't looked at that in years so I'm worried it's probably not
> great. You probably be better off not using the --two-passes option. :/
> I should remove it.
Haha no I need it :D I was just testing what this tool can do. I also
notice that --two-passes seems quite bad to read. But hey I found
something! :D Good to know that you are not using it. I will not use it
then. Thanks.
>
> regards,
> dan carpenter
>
>
next prev parent reply other threads:[~2021-08-25 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 18:25 [PATCH] fs/ntfs3: Remove unnecessary condition checking from ntfs_file_read_iter Kari Argillander
2021-08-25 19:17 ` Dan Carpenter
2021-08-25 19:31 ` Kari Argillander [this message]
2021-09-02 16:26 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825193100.fix4o2p7swifru5o@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox