From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C06F472 for ; Sun, 29 Aug 2021 09:56:36 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id p15so20104180ljn.3 for ; Sun, 29 Aug 2021 02:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=06IJ8wv8VYpmrLf54oJDv7/8FotCGMOf/f2pOdPg7sg=; b=bZmgDWQIcYClPh9dxk+5kt1yNkQ8p0mgD1TAtGtU0g7eDn8UKdZ+IKuoGmI8BiZYHD mrW6M5ZEInqAytHA0c6uKFU6c6shXXvDOaeuxNdHsfxBPHiYKLx+rfhFKi7sZvWxtEs1 d00A+utqmIlhzltXws86uhNTUEIcgiNQDS8YCFMtD2zV0ggNClMP+0pwhv5BjJY5ShFn OO0mGy41AvM7CMzgKECI6LW7bd7QuRc28CQ6ERowJHO/kJm9RjFX/jbYD5EDRRbI4UxC GIVCGVsmZvPPznqpTLJDRmY1Rjm8OnMqrUO26nNw1rkYU+KSUQYtutSHbjouXngvcUcY bBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=06IJ8wv8VYpmrLf54oJDv7/8FotCGMOf/f2pOdPg7sg=; b=J7G7Feu9qf+48X+SKQRCpoNWdHElRF69kgygfWeaQV6MavxMO9jzzbomLg5rlDJ/mV WNYOsB+D+Ah6nKGyE3SkuyqLGOWSurJQzXHm0Bavfh6RM52/PM0uwyfok/7UUVKh7o2G 6jl58ysRNkRVsWLEvrkcY1kGqyGKuInopRBOFWMv8QkLBhkfFUroaGE4SpczmYwtcv6C RadS43eNAAsYT6YCPLdtAAMoMHE9A+e/sFGUpE+BT4/hl745sZi3SRhlcfHDwAiwYTMt 2Kv0fZfuJMz+/ikCip80sat68RWFFI2v9nUtPky1+g6LdIWH/ANohaiGVAYc5SkUHcyK l3tQ== X-Gm-Message-State: AOAM530ptj6WDgjbzaUzlG76uUYue67RLEu/KX06N+2cvxyb93F1TmEQ eLrmdR5Sw9DZ4OGA5GgUDHw= X-Google-Smtp-Source: ABdhPJybXuFCOlJmL+50BGFrqBEJAfgNz3geVl43CRaDiurUM3o/ebil5YGzAknhIdq/76WCd/AMXQ== X-Received: by 2002:a2e:858e:: with SMTP id b14mr15701090lji.508.1630230994928; Sun, 29 Aug 2021 02:56:34 -0700 (PDT) Received: from localhost.localdomain (37-33-245-172.bb.dnainternet.fi. [37.33.245.172]) by smtp.gmail.com with ESMTPSA id d6sm1090521lfi.57.2021.08.29.02.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 02:56:34 -0700 (PDT) From: Kari Argillander To: Konstantin Komarov , ntfs3@lists.linux.dev Cc: Kari Argillander , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, =?UTF-8?q?Pali=20Roh=C3=A1r?= , Matthew Wilcox , Christian Brauner Subject: [PATCH v3 1/9] fs/ntfs3: Remove unnecesarry mount option noatime Date: Sun, 29 Aug 2021 12:56:06 +0300 Message-Id: <20210829095614.50021-2-kari.argillander@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210829095614.50021-1-kari.argillander@gmail.com> References: <20210829095614.50021-1-kari.argillander@gmail.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove unnecesarry mount option noatime because this will be handled by VFS. Our option parser will never get opt like this. Acked-by: Christian Brauner Reviewed-by: Christoph Hellwig Signed-off-by: Kari Argillander --- Documentation/filesystems/ntfs3.rst | 4 ---- fs/ntfs3/super.c | 7 ------- 2 files changed, 11 deletions(-) diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst index ffe9ea0c1499..af7158de6fde 100644 --- a/Documentation/filesystems/ntfs3.rst +++ b/Documentation/filesystems/ntfs3.rst @@ -85,10 +85,6 @@ acl Support POSIX ACLs (Access Control Lists). Effective if supported by Kernel. Not to be confused with NTFS ACLs. The option specified as acl enables support for POSIX ACLs. -noatime All files and directories will not update their last access - time attribute if a partition is mounted with this parameter. - This option can speed up file system operation. - =============================================================================== ToDo list diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 17ee715ab539..267f123b0109 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -216,7 +216,6 @@ enum Opt { Opt_nohidden, Opt_showmeta, Opt_acl, - Opt_noatime, Opt_nls, Opt_prealloc, Opt_no_acs_rules, @@ -235,7 +234,6 @@ static const match_table_t ntfs_tokens = { { Opt_sparse, "sparse" }, { Opt_nohidden, "nohidden" }, { Opt_acl, "acl" }, - { Opt_noatime, "noatime" }, { Opt_showmeta, "showmeta" }, { Opt_nls, "nls=%s" }, { Opt_prealloc, "prealloc" }, @@ -326,9 +324,6 @@ static noinline int ntfs_parse_options(struct super_block *sb, char *options, ntfs_err(sb, "support for ACL not compiled in!"); return -EINVAL; #endif - case Opt_noatime: - sb->s_flags |= SB_NOATIME; - break; case Opt_showmeta: opts->showmeta = 1; break; @@ -575,8 +570,6 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root) seq_puts(m, ",prealloc"); if (sb->s_flags & SB_POSIXACL) seq_puts(m, ",acl"); - if (sb->s_flags & SB_NOATIME) - seq_puts(m, ",noatime"); return 0; } -- 2.25.1