From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE8672 for ; Sun, 29 Aug 2021 09:56:52 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id bq28so24556051lfb.7 for ; Sun, 29 Aug 2021 02:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v3egmclPp6Wx1/0tawWJ+PILwmaso1iDcpgDHnZfUHs=; b=BDGEEtVed7NONusJZRJVpHxLj7oDNbgLuwQd6K6oa8GlLEkaC3/TZdxnd25z8eXsEQ bqXnF0mb9zNnMkL1TcmikekU70b0nLu2etltRVyh6j/O5d2qFB9epT2APsunY6fRlrSy FweebPe/eHMe8Or398yW4JX9RoSnzoZoRxq3L1B+5U5MbjtZDEYKdSG1v7Dqw/SX39rF L9ZSU05Jl6xWInM/nEmMNdysh7a8g8mMqxGIfVBi4uKpPOpPzoSts+WGgTgZRWi37FsF AKCukGuhBVmSFN8cVjn6jIihHRNVpr3SiYhJfbVTyVsHNkkxXvAxnA5L/BTboNxlR8wk ZX/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v3egmclPp6Wx1/0tawWJ+PILwmaso1iDcpgDHnZfUHs=; b=i6PvWuC9gJzq2JV1u87cI/RSGphRFewsjfY5LwMBO9cVXVjYtdqIQtfDwjElD7xf0i zPg7UB/KzlmZanDJV9r1hGdFxeS4q8E1DDBagD/A5iBJa4H7hWGolvJuglbU1a12nVac 5UXA+sBN+qAP85TXsIj8Azd2ijUwc3UocuNieepgCk9c3XkySWhuu4Qqybfu5tBWWmZb 063/TWgN681i5ZSVYb/IiXQWH9FTGfnNmb7eSOq2+RQfSGEVtu3hV0tl56hbNsGCFpLv nL1n23iLc43/Q3viTubcDCaqJKszSh1W2bLfcJVd5mi4Z6LrkSnJacMZQlZvuawnjPuj KU4A== X-Gm-Message-State: AOAM531vDotPxcpqOUnO/8VSIBzuHxrt407CGlVpDg5ZROD9S6MiI55s jaatVDmjxLuXB8vtq3xxvWU= X-Google-Smtp-Source: ABdhPJz2qfjqW8rdnNGzA4UGKKEppM5B4O4oRkU43Z12Y+bss2f8O8bAZo0YQ0ZnJIHjMOr0xWQx1g== X-Received: by 2002:a05:6512:ac7:: with SMTP id n7mr5086161lfu.469.1630231010634; Sun, 29 Aug 2021 02:56:50 -0700 (PDT) Received: from localhost.localdomain (37-33-245-172.bb.dnainternet.fi. [37.33.245.172]) by smtp.gmail.com with ESMTPSA id d6sm1090521lfi.57.2021.08.29.02.56.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 02:56:50 -0700 (PDT) From: Kari Argillander To: Konstantin Komarov , ntfs3@lists.linux.dev Cc: Kari Argillander , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, =?UTF-8?q?Pali=20Roh=C3=A1r?= , Matthew Wilcox , Christian Brauner Subject: [PATCH v3 5/9] fs/ntfs3: Init spi more in init_fs_context than fill_super Date: Sun, 29 Aug 2021 12:56:10 +0300 Message-Id: <20210829095614.50021-6-kari.argillander@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210829095614.50021-1-kari.argillander@gmail.com> References: <20210829095614.50021-1-kari.argillander@gmail.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit init_fs_context() is meant to initialize s_fs_info (spi). Move spi initializing code there which we can initialize before fill_super(). Signed-off-by: Kari Argillander --- fs/ntfs3/super.c | 41 ++++++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 99102a146cf5..b2a3f947542b 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -870,7 +870,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) const struct VOLUME_INFO *info; u32 idx, done, bytes; struct ATTR_DEF_ENTRY *t; - u16 *upcase = NULL; + u16 *upcase; u16 *shared; bool is_ro; struct MFT_REF ref; @@ -885,9 +885,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) sb->s_time_gran = NTFS_TIME_GRAN; // 100 nsec sb->s_xattr = ntfs_xattr_handlers; - ratelimit_state_init(&sbi->msg_ratelimit, DEFAULT_RATELIMIT_INTERVAL, - DEFAULT_RATELIMIT_BURST); - sbi->options->nls = ntfs_load_nls(sbi->options->nls_name); if (IS_ERR(sbi->options->nls)) { sbi->options->nls = NULL; @@ -917,12 +914,6 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) sb->s_maxbytes = 0xFFFFFFFFull << sbi->cluster_bits; #endif - mutex_init(&sbi->compress.mtx_lznt); -#ifdef CONFIG_NTFS3_LZX_XPRESS - mutex_init(&sbi->compress.mtx_xpress); - mutex_init(&sbi->compress.mtx_lzx); -#endif - /* * Load $Volume. This should be done before LogFile * 'cause 'sbi->volume.ni' is used 'ntfs_set_state' @@ -1207,11 +1198,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc) goto out; } - sbi->upcase = upcase = kvmalloc(0x10000 * sizeof(short), GFP_KERNEL); - if (!upcase) { - err = -ENOMEM; - goto out; - } + upcase = sbi->upcase; for (idx = 0; idx < (0x10000 * sizeof(short) >> PAGE_SHIFT); idx++) { const __le16 *src; @@ -1421,10 +1408,21 @@ static int ntfs_init_fs_context(struct fs_context *fc) goto ok; sbi = kzalloc(sizeof(struct ntfs_sb_info), GFP_NOFS); - if (!sbi) { - kfree(opts); - return -ENOMEM; - } + if (!sbi) + goto free_opts; + + sbi->upcase = kvmalloc(0x10000 * sizeof(short), GFP_KERNEL); + if (!sbi->upcase) + goto free_sbi; + + ratelimit_state_init(&sbi->msg_ratelimit, DEFAULT_RATELIMIT_INTERVAL, + DEFAULT_RATELIMIT_BURST); + + mutex_init(&sbi->compress.mtx_lznt); +#ifdef CONFIG_NTFS3_LZX_XPRESS + mutex_init(&sbi->compress.mtx_xpress); + mutex_init(&sbi->compress.mtx_lzx); +#endif sbi->options = opts; fc->s_fs_info = sbi; @@ -1433,6 +1431,11 @@ static int ntfs_init_fs_context(struct fs_context *fc) fc->ops = &ntfs_context_ops; return 0; +free_opts: + kfree(opts); +free_sbi: + kfree(sbi); + return -ENOMEM; } // clang-format off -- 2.25.1