From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577893FC2 for ; Sun, 29 Aug 2021 14:43:04 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id c8so13053980lfi.3 for ; Sun, 29 Aug 2021 07:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vi12hNY0vhgn8mLCqZgcRjNvZYn/ptAUd78nem7zDq4=; b=cTQuN78djINDAQssTLQIH/74drUr9Hb0HB8nJyPEd4+B1hbL8eWMDDQwJ7dMMUyaZj U499KSS2J+AR7bQDpgVK3XxR62dw/7gq1apwvIyqLJrMrk4JNeTOjZjLlhKIFN+eaMTv 7hhuibxe/4Stkmi6UUt47lm5zsiX2TL1EXw8AJIYTCQFUoel32qsTaPeQIAfp8HJ5jtb S8ZUT6g4omL96B+lsAMr7zdpPcXxi1F1TR7DiZIQYqCumD+hijjkC63Hs2HhbnCzwrhg cjGFuqRt25efc+/lxuJJ0mRNkTBkj7JNRBg7ldt9aoG0UFogbLrR10O/vmvfV8bXHZYh OLlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vi12hNY0vhgn8mLCqZgcRjNvZYn/ptAUd78nem7zDq4=; b=QXSCRI7XqqBCmt+Cjj4BUmUf6bq9A6e+0XqNCyO4olJLcv6QkzJyeFjk5tpGerseCF TNeNiXBN4Lm7DzI4sUs/Xeg0PKhs+2TwvKJcUEL/Gf35zJd0ry5qIIlC7F6HVOeSTEWS wGB8RSzIZKV+nCL6dlblV+AbYl8fkUGGZuDqED9pucSdbZ1t0anzDPGZJhK8w/clIDVC NJZjep9wFoph2kqngWhvuBeotpBBltjD2BJUUolZFW8sqUloxmOML8X0/3lVR2kB5TYs pi5aJYw0XkfcQR+svwA3gTxHGua1cg+g9SedtmTl15lSXIc+FLYVQZtOO+86YF26T/TH gQVA== X-Gm-Message-State: AOAM533o29fKjSczOuKG6KN0g0mKXqGKPs6XmXgEj/LENeUX50znfR4v Q+IRTQCetocIKAj0hiKyfNI= X-Google-Smtp-Source: ABdhPJw/4PUswN4lra3ZqGZzoe9lPY2QQLqYXBn22OYOKWmGo4+MWq8Fzrvo9ygtCXLex8We+z/a6A== X-Received: by 2002:a05:6512:3407:: with SMTP id i7mr2831754lfr.254.1630248182388; Sun, 29 Aug 2021 07:43:02 -0700 (PDT) Received: from localhost.localdomain (37-33-245-172.bb.dnainternet.fi. [37.33.245.172]) by smtp.gmail.com with ESMTPSA id q9sm1243403lfn.170.2021.08.29.07.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Aug 2021 07:43:01 -0700 (PDT) From: Kari Argillander To: Konstantin Komarov , ntfs3@lists.linux.dev Cc: Kari Argillander , linux-kernel@vger.kernel.org Subject: [PATCH] fs/ntfs3: Change how module init/info messages are displayed Date: Sun, 29 Aug 2021 17:42:39 +0300 Message-Id: <20210829144239.58213-1-kari.argillander@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Usually in file system init() messages are only displayed in info level. Change level from notice to info, but keep CONFIG_NTFS3_64BIT_CLUSTER in notice level. Also this need even more attention so let's put big warning here so that nobody will not try accidentally use it. There is also no good reason to display internal stuff like binary tree search. This is always on option which can only disabled for debugging purposes by developer. Also this message does not even check if developer has disabled it or not so it is useless info. Signed-off-by: Kari Argillander --- fs/ntfs3/super.c | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 17ee715ab539..7895039cf673 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -1430,21 +1430,14 @@ static int __init init_ntfs_fs(void) { int err; - pr_notice("ntfs3: Index binary search\n"); - pr_notice("ntfs3: Hot fix free clusters\n"); - pr_notice("ntfs3: Max link count %u\n", NTFS_LINK_MAX); + pr_info("ntfs3: Max link count %u\n", NTFS_LINK_MAX); -#ifdef CONFIG_NTFS3_FS_POSIX_ACL - pr_notice("ntfs3: Enabled Linux POSIX ACLs support\n"); -#endif -#ifdef CONFIG_NTFS3_64BIT_CLUSTER - pr_notice("ntfs3: Activated 64 bits per cluster\n"); -#else - pr_notice("ntfs3: Activated 32 bits per cluster\n"); -#endif -#ifdef CONFIG_NTFS3_LZX_XPRESS - pr_notice("ntfs3: Read-only lzx/xpress compression included\n"); -#endif + if (IS_ENABLED(CONFIG_NTFS3_FS_POSIX_ACL)) + pr_info("ntfs3: Enabled Linux POSIX ACLs support\n"); + if (IS_ENABLED(CONFIG_NTFS3_64BIT_CLUSTER)) + pr_notice("ntfs3: Warning: Activated 64 bits per cluster. Windows does not support this\n"); + if (IS_ENABLED(CONFIG_NTFS3_LZX_XPRESS)) + pr_info("ntfs3: Read-only LZX/Xpress compression included\n"); err = ntfs3_init_bitmap(); if (err) @@ -1484,15 +1477,11 @@ static void __exit exit_ntfs_fs(void) MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("ntfs3 read/write filesystem"); -MODULE_INFO(behaviour, "Index binary search"); -MODULE_INFO(behaviour, "Hot fix free clusters"); #ifdef CONFIG_NTFS3_FS_POSIX_ACL MODULE_INFO(behaviour, "Enabled Linux POSIX ACLs support"); #endif #ifdef CONFIG_NTFS3_64BIT_CLUSTER -MODULE_INFO(cluster, "Activated 64 bits per cluster"); -#else -MODULE_INFO(cluster, "Activated 32 bits per cluster"); +MODULE_INFO(cluster, "Warning: Activated 64 bits per cluster. Windows does not support this"); #endif #ifdef CONFIG_NTFS3_LZX_XPRESS MODULE_INFO(compression, "Read-only lzx/xpress compression included"); -- 2.30.2