public inbox for ntfs3@lists.linux.dev
 help / color / mirror / Atom feed
From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev
Cc: Kari Argillander <kari.argillander@gmail.com>,
	linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: [PATCH v2 2/4] fs/ntfs3: Place Comparisons constant right side of the test
Date: Tue,  7 Sep 2021 11:34:39 +0300	[thread overview]
Message-ID: <20210907083441.3212-3-kari.argillander@gmail.com> (raw)
In-Reply-To: <20210907083441.3212-1-kari.argillander@gmail.com>

For better code readability place constant always right side of the
test. This will also address checkpatch warning.

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
---
 fs/ntfs3/frecord.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index d1477cabe3c7..d3c1c46cfb0a 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -1606,7 +1606,7 @@ struct ATTR_FILE_NAME *ni_fname_type(struct ntfs_inode *ni, u8 name_type,
 
 	*le = NULL;
 
-	if (FILE_NAME_POSIX == name_type)
+	if (name_type == FILE_NAME_POSIX)
 		return NULL;
 
 	/* Enumerate all names. */
-- 
2.25.1


  parent reply	other threads:[~2021-09-07  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07  8:34 [PATCH v2 0/4] fs/ntfs3: Fix various styling issues Kari Argillander
2021-09-07  8:34 ` [PATCH v2 1/4] fs/ntfs3: Remove '+' before constant in ni_insert_resident() Kari Argillander
2021-09-07  8:34 ` Kari Argillander [this message]
2021-09-07  8:34 ` [PATCH v2 3/4] fs/ntfs3: Remove braces from single statment block Kari Argillander
2021-09-07  8:34 ` [PATCH v2 4/4] fs/ntfs3: Remove tabs before spaces from comment Kari Argillander
2021-09-16 14:07 ` [PATCH v2 0/4] fs/ntfs3: Fix various styling issues Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907083441.3212-3-kari.argillander@gmail.com \
    --to=kari.argillander@gmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox