From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: Joe Perches <joe@perches.com>,
ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] fs/ntfs3: Use consistent spacing around '+'
Date: Tue, 7 Sep 2021 19:25:20 +0300 [thread overview]
Message-ID: <20210907162520.pi6djmu32iajayme@kari-VirtualBox> (raw)
In-Reply-To: <bb8fff4c-ae09-cab0-cd71-c34b872c9211@paragon-software.com>
On Tue, Sep 07, 2021 at 07:23:13PM +0300, Konstantin Komarov wrote:
>
>
> On 02.09.2021 11:10, Kari Argillander wrote:
> > On Wed, Sep 01, 2021 at 09:22:19PM -0700, Joe Perches wrote:
> >> On Tue, 2021-08-31 at 21:15 +0300, Kari Argillander wrote:
> >>> Use consistent spacing around '+' for better code reading. Checkpatch
> >>> will also be happy.
> >>
> >> I think you should remove the + instead
> >
> > Konstantin can you look this as this was introduce by you just couple
> > days ago?
> >
> >>
> >>> diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
> >> []
> >>> @@ -1451,7 +1451,7 @@ int ni_insert_resident(struct ntfs_inode *ni, u32 data_size,
> >>> attr->res.flags = RESIDENT_FLAG_INDEXED;
> >>>
> >>>
> >>> /* is_attr_indexed(attr)) == true */
> >>> - le16_add_cpu(&ni->mi.mrec->hard_links, +1);
> >>> + le16_add_cpu(&ni->mi.mrec->hard_links, + 1);
> >>
> >> le16_add_cpu(&ni->mi.mrec->hard_links, 1);
> >>
> >>
>
> Hi, Kari, Joe!
> Yes, '+' can be removed, it was added for better visibility,
> but it's subjective.
> After checking code - it's the only place with '+1', so let's remove it.
Already done in v2 [1].
[1]: lore.kernel.org/ntfs3/20210907083441.3212-1-kari.argillander@gmail.com
next prev parent reply other threads:[~2021-09-07 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 18:15 [PATCH 0/5] fs/ntfs3: Fix various styling issues Kari Argillander
2021-08-31 18:15 ` [PATCH 1/5] fs/ntfs3: Use kmalloc_array over kmalloc with multiply Kari Argillander
2021-09-01 2:40 ` Joe Perches
2021-09-01 13:24 ` Kari Argillander
2021-09-02 14:03 ` David Laight
2021-08-31 18:15 ` [PATCH 2/5] fs/ntfs3: Use consistent spacing around '+' Kari Argillander
2021-09-02 4:22 ` Joe Perches
2021-09-02 8:10 ` Kari Argillander
2021-09-07 16:23 ` Konstantin Komarov
2021-09-07 16:25 ` Kari Argillander [this message]
2021-08-31 18:15 ` [PATCH 3/5] fs/ntfs3: Place Comparisons constant right side of the test Kari Argillander
2021-08-31 18:15 ` [PATCH 4/5] fs/ntfs3: Remove braces from single statment block Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907162520.pi6djmu32iajayme@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox