From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000
Date: Thu, 9 Sep 2021 15:57:46 +0300 [thread overview]
Message-ID: <20210909125746.3io24xmh377ca4nh@kari-VirtualBox> (raw)
In-Reply-To: <20210909123034.mlsq57bsjvonwwd2@kari-VirtualBox>
On Thu, Sep 09, 2021 at 03:30:34PM +0300, Kari Argillander wrote:
> On Thu, Sep 09, 2021 at 01:58:04PM +0300, Konstantin Komarov wrote:
> > xfstest 041 works with 3003, so we need to
And it would be good to write generic/041. This way grepping is little
easier.
> > raise limit.
>
> No need to linebreak.
>
> >
> > Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
> > ---
> > fs/ntfs3/ntfs.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/ntfs3/ntfs.h b/fs/ntfs3/ntfs.h
> > index 6bb3e595263b..0006481db7fa 100644
> > --- a/fs/ntfs3/ntfs.h
> > +++ b/fs/ntfs3/ntfs.h
> > @@ -21,7 +21,8 @@
> > #define NTFS_NAME_LEN 255
> >
> > /* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
> > -#define NTFS_LINK_MAX 0x400
> > +/* xfstest 041 creates 3003 hardlinks. */
>
> It think comment is unnecessary here. If you think this is necassarry
> comment then please but it same comment block as last row.
>
> > +#define NTFS_LINK_MAX 4000
>
> What draw backs there is if this is 4000? We really do not care about
> xfstests if we have some reason to not do this. This info can be but
> to commit message.
>
> > //#define NTFS_LINK_MAX 0xffff
>
> We can probably same time get rid of this.
>
> >
> > /*
> > --
> > 2.28.0
> >
>
next prev parent reply other threads:[~2021-09-09 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 10:58 [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Konstantin Komarov
2021-09-09 12:30 ` Kari Argillander
2021-09-09 12:57 ` Kari Argillander [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-13 15:09 [PATCH 0/3] fs/ntfs3: Speed up hardlink creation Konstantin Komarov
2021-09-13 15:14 ` [PATCH 2/3] fs/ntfs3: Change max hardlinks limit to 4000 Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909125746.3io24xmh377ca4nh@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox