From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D0D2C82 for ; Fri, 15 Oct 2021 16:56:49 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so9762614pjb.1 for ; Fri, 15 Oct 2021 09:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vfh8ldDPWodO2+NAKgs+77i4cirGVTrsvlhR7sq6n14=; b=MF0yf140gbDAdW4BxnOXdsQIbZ1Zs20bgZWJgGQJccJRdMKWf0Z7qJMeg/xUZ/rSs6 VG3QCkdC2Gak2gGrkvLjpOyqG7g5cIFwioohIVF4DnPVlIrbB81BnizHen6OonQjrvMj EAa7kecUI8Ha/nnI/LS4mNOBQr2yiVBjBbg4U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vfh8ldDPWodO2+NAKgs+77i4cirGVTrsvlhR7sq6n14=; b=sRrPFYnaDy02GNeKtUgyVxgq+1Q8MEj37+TUoVUVojEU6teacLxtat/pvK+JwOBFBp TpT/IeYaMQhmLBqOmQp2E5JjHX3awNhHSt4tM70+uzFtrgGcfOo3JOFcRoysOLGIvVEs GnJvWnMOO/PPfQtI4VOymCLjXYtptarVhvGGx9TxdTc2dIQINea1XVDYIBZZPQ6eX9Qd 6TTOClh8p5xBFLK1Z3ZF4FY8eOJ/ty33qbNOKItsoIUqBq9Ep9Pj5sM/baprMpJTZZ+E SoaAd8MVmiStQFepCwFOGXcBX4zZL2wBtGAEbXIxsPEvYLUQ7GKzKUGWqclV1L/VZcJP b04Q== X-Gm-Message-State: AOAM533jJm5pFvduywJcKfWCZZi8A31p2c9j+fJG1BdQqTss1SoLX25l 9zw+3wOTYsZsuPuMKdVpYAQiCw== X-Google-Smtp-Source: ABdhPJwnnQ3ulrXVGFg4s+UA3ddGM8HwmAEnk5XYfNq6HtGw+i5b3OvChqf29ta/Idk60aluKwm2lg== X-Received: by 2002:a17:903:18d:b0:13e:f1ef:d80c with SMTP id z13-20020a170903018d00b0013ef1efd80cmr11974419plg.63.1634317008672; Fri, 15 Oct 2021 09:56:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t125sm5518370pfc.119.2021.10.15.09.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 09:56:48 -0700 (PDT) Date: Fri, 15 Oct 2021 09:56:47 -0700 From: Kees Cook To: Christoph Hellwig Cc: Jens Axboe , Coly Li , Mike Snitzer , Song Liu , David Sterba , Josef Bacik , Theodore Ts'o , OGAWA Hirofumi , Dave Kleikamp , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Phillip Lougher , Jan Kara , linux-block@vger.kernel.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, reiserfs-devel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 22/30] reiserfs: use bdev_nr_bytes instead of open coding it Message-ID: <202110150956.A0360E2D01@keescook> References: <20211015132643.1621913-1-hch@lst.de> <20211015132643.1621913-23-hch@lst.de> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015132643.1621913-23-hch@lst.de> On Fri, Oct 15, 2021 at 03:26:35PM +0200, Christoph Hellwig wrote: > Use the proper helper to read the block device size and remove two > cargo culted checks that can't be false. > > Signed-off-by: Christoph Hellwig Reviewed-by: Kees Cook -- Kees Cook